Re: [Django] #8713: Django core depends on django.contrib

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody
<django@…> | Status: new
Type: New feature | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by aaugustin):

Running the command provided by the OP I still found the following uses of
contrib in core.

Action needed:

1. `django/middleware/doc.py`: checks `request.user.is_active/is_staff`
2. `django/test/client.py`: depends on `django.contrib.auth` (at least)
3. `django/test/testcases.py`: depends on `django.contrib.staticfiles` (at
least)
4. `django/views/defaults.py`: `shortcut` has a comment saying it should
be deprecated in Django 2.0, but I don't see much point in waiting; we
have a well established deprecation policy now and this is a trivial case.

No action needed:

1. `django/core/management/commands/cleanup.py`: it's deprecated
2. `django/db/models/base.py`: it's just a comment
3. `django/middleware/cache.py`: tests `request.user.is_authenticated()`
when `CACHE_MIDDLEWARE_ANONYMOUS_ONLY` is set. #15201 proposes to decouple
`CACHE_MIDDLEWARE_ANONYMOUS_ONLY` from `django.contrib.auth` by testing
only if the response varies on cookie. That covers the issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody
<django@…> | Status: new
Type: New feature | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by aaugustin):

3f2befc93163e0666dcc4f745288b98306de4b8e addressed action 4.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:14>

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody
<django@…> | Status: new
Type: New feature | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by aaugustin):

I filed #20126 for action 1.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:15>

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody
<django@…> | Status: new
Type: New feature | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by ramiro):

I filed #20739 for item 2.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:16>

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody
<django@…> | Status: new
Type: New feature | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by ramiro):

I filed #20915 for item 2.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:17>

[Django]

#8713: Django core depends on django.contrib
-------------------------------------+-------------------------------------
Reporter: Piotr Lewandowski | Owner: nobody

<django@…> | Status: closed

Type: New feature | Version: master

Component: Core (Other) | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by aaugustin):

* status: new => closed
* resolution: => fixed

Comment:

Since all changes identified in comment 13 have been done, except the one
that's still tracked in #20915, I believe we can close this ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/8713#comment:18>