Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
-------------------------------------+-------------------------------------
Reporter: John Shaffer | Owner: nobody
<jshaffer2112@…> | Status: new
Type: | Version: master
Cleanup/optimization | Resolution:
Component: Database layer | Triage Stage: Accepted
(models, ORM) | Needs documentation: 0
Severity: Normal | Patch needs improvement: 1
Keywords: postgresql psycopg | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by timo):

* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/4492#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#4492: Provide tests for mixed-case column names
-------------------------------------+-------------------------------------
Reporter: John Shaffer | Owner: nobody
<jshaffer2112@…> | Status: new
Type: | Version: master
Cleanup/optimization | Resolution:
Component: Database layer | Triage Stage: Accepted
(models, ORM) | Needs documentation: 0
Severity: Normal | Patch needs improvement: 1
Keywords: postgresql psycopg | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------

Comment (by velis):

I just want to clarify: it says tests are needed, but the appropriate
checkbox is not ticked. So, is it the tests that are needed or is there
something more to this ticket?
p.s.: I'm sprinting django on PyCon UK and I'm looking at this ticket
because I have dealt with this problem before. So I know what the issue
was, I can write the appropriate tests, but I also want to make it right
so that my first contribution wouldn't end up a failure :)

--
Ticket URL: <https://code.djangoproject.com/ticket/4492#comment:16>

[Django]

#4492: Provide tests for mixed-case column names
-------------------------------------+-------------------------------------
Reporter: John Shaffer | Owner: nobody
<jshaffer2112@…> | Status: new
Type: | Version: master
Cleanup/optimization | Resolution:
Component: Database layer | Triage Stage: Accepted
(models, ORM) | Needs documentation: 0
Severity: Normal | Patch needs improvement: 1
Keywords: postgresql psycopg | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------

Comment (by velis):

https://github.com/django/django/pull/1667

Please review

--
Ticket URL: <https://code.djangoproject.com/ticket/4492#comment:17>

[Django]

#4492: Provide tests for mixed-case column names
-------------------------------------+-------------------------------------
Reporter: John Shaffer | Owner: nobody

<jshaffer2112@…> | Status: closed
Type: | Version: master
Cleanup/optimization | Resolution: fixed

Component: Database layer | Triage Stage: Accepted
(models, ORM) | Needs documentation: 0
Severity: Normal | Patch needs improvement: 1
Keywords: postgresql psycopg | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------

Changes (by timo):

* status: new => closed
* resolution: => fixed

Comment:

On further investigation, I think we have tests to cover this. In
particular, if I comment out the fix from [6507], I get a failure in
`test_generic_relation (backends.tests.SequenceResetTest)`, and here are
some models with mixed case column names:

{{{
aggregation_regress/models.py: Entry = models.CharField(unique=True,
max_length=50)
aggregation_regress/models.py: Clue = models.CharField(max_length=150)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/4492#comment:18>