Re: [Django] #3461: DatabaseWrapper should pass through args and kwargs to underlying database adapter
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: auvipy
<metajack@…> |
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by auvipy):
* status: new => assigned
* owner: cgrady => auvipy
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner:
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by auvipy):
* owner: auvipy =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:16>
Django
adapter
-------------------------------------+-------------------------------------
<metajack@…> | Tabone
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: (none) => Olivier Tabone
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:17>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Olivier
<metajack@…> | Tabone
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Olivier Tabone):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 1 => 0
Comment:
please comment on [https://github.com/django/django/pull/7514 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:18>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Olivier
<metajack@…> | Tabone
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:19>
Django
adapter
-------------------------------------+-------------------------------------
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: Olivier Tabone => Asif Saifuddin Auvi
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:20>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Asif Saifuddin Auvi):
* needs_docs: 0 => 1
* needs_better_patch: 1 => 0
Comment:
I am unsure where to put the doc changes, so asked in the pr but did not
get any response. after adding docs and release note I will squash commits
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:21>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
comment:9 contains a suggestion about the documentation. The content is
more important; the location can easily be changed if needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:22>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:23>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:24>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:25>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Asif Saifuddin Auvi):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:26>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> Currently the DatabaseWrapper (at least for the postgresql_psycopg2end)
> does not pass args and kwargs for cursor() calls to the underlying
> database adapter. This makes it impossible to use the adapter fully at
> the low level. For example, to use dict cursors in psycopg2 you have to
> pass a different cursor factory via the cursor_factory keyword argument
> to cursor(). The attached patch passes through args and kwargs for
> cursor() calls.
New description:
Currently the DatabaseWrapper (at least for the postgresql) does not pass
args and kwargs for cursor() calls to the underlying database adapter.
This makes it impossible to use the adapter fully at the low level. For
example, to use dict cursors in psycopg2 you have to pass a different
cursor factory via the cursor_factory keyword argument to cursor(). The
attached patch passes through args and kwargs for cursor() calls.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:27>
Django
adapter
-------------------------------------+-------------------------------------
Reporter: Jack Moffitt | Owner: Asif
<metajack@…> | Saifuddin Auvi
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
needs retarget 3.2 and add missing docs :( hopefully, make this happen
this time!
--
Ticket URL: <https://code.djangoproject.com/ticket/3461#comment:28>