Re: [Django] #5046: views/debug.py: Display string of UnicodeError

5 views
Skip to first unread message

Django

unread,
Jul 31, 2017, 6:47:22 PM7/31/17
to django-...@googlegroups.com
#5046: views/debug.py: Display string of UnicodeError
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Adrian
<hv@…> | Holovaty
Type: | Status: closed
Cleanup/optimization |
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: unicode | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* type: => Cleanup/optimization
* ui_ux: => 0
* component: Metasystem => Error reporting
* severity: => Normal
* easy: => 0


Comment:

10 years later, I noticed these lines aren't tested. I'm not sure if this
feature is still needed in a Python 3-only world as I'd think the
problematic string would appear in the " Local vars" section of the
traceback but there aren't steps to reproduce so perhaps you could give an
insight if you remember anything about the original issue, Thomas?

In case the feature in still useful, I made a
[https://github.com/django/django/pull/8834 PR] to add a test.

--
Ticket URL: <https://code.djangoproject.com/ticket/5046#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 2, 2017, 3:33:31 PM8/2/17
to django-...@googlegroups.com
#5046: views/debug.py: Display string of UnicodeError
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Adrian
<hv@…> | Holovaty
Type: | Status: closed
Cleanup/optimization |
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: unicode | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"74b7a20fe6973a53923059795cb538d094c925d8" 74b7a20]:
{{{
#!CommitTicketReference repository=""
revision="74b7a20fe6973a53923059795cb538d094c925d8"
Refs #5046 -- Tested the 'unicode hint' in the technical 500 debug view.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/5046#comment:9>

Django

unread,
Aug 3, 2017, 2:20:32 AM8/3/17
to django-...@googlegroups.com
#5046: views/debug.py: Display string of UnicodeError
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Adrian
<hv@…> | Holovaty
Type: | Status: closed
Cleanup/optimization |
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: unicode | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Thomas Güttler):

thank you

--
Ticket URL: <https://code.djangoproject.com/ticket/5046#comment:10>

Reply all
Reply to author
Forward
0 new messages