[Django] #18170: [PATCH] Break-out password reset confirmation so that it is re-usable.
Django
----------------------------------------+--------------------
Reporter: thomas.david.vaughan@… | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.auth | Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------------+--------------------
Currrently, an app that wishes to override password_reset_confirm has to
copy-and-paste the confirmation code into its view. This moves that code
into a utils module for re-use.
For an example, please see password_reset_confirm in:
https://github.com/rentalita/django-
userena/blob/bootstrap/userena/views.py
Patches for 1.3.1 and 1.4 are attached.
--
Ticket URL: <https://code.djangoproject.com/ticket/18170>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: | Owner: nobody
thomas.david.vaughan@… | Status: new
Type: Uncategorized | Version: 1.4
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
I don't think django 1.3 or django 1.4 will get this patch. But for 1.5
this seems good. Of course, the function is internal and thus use at your
own risk - it can change underneath you, even in a minor release.
See the pull request https://github.com/django/django/pull/12 for a patch
against head.
--
Ticket URL: <https://code.djangoproject.com/ticket/18170#comment:1>
Django
Reporter: | Owner: nobody
thomas.david.vaughan@… | Status: new
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: bmispelon@… (added)
Comment:
Personally, I'd be more favorable to an approach like #17209
--
Ticket URL: <https://code.djangoproject.com/ticket/18170#comment:3>
Django
Reporter: | Owner: nobody
thomas.david.vaughan@… | Status: closed
Type: New feature | Version: 1.4
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => wontfix
Comment:
Given the comments on the PR and the fact that it was closed, I'm going to
close this.
--
Ticket URL: <https://code.djangoproject.com/ticket/18170#comment:4>