[Django] #17642: min_num on admin inline formsets
Django
--------------------------------------+------------------------------------
Reporter: krzysztof.szczesny@… | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version:
Severity: Normal | Keywords: admin min_num formsets
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
the min_num parameter should be supported in admin inlines
--
Ticket URL: <https://code.djangoproject.com/ticket/17642>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: | Owner: nobody
krzysztof.szczesny@… | Status: new
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage:
Keywords: admin min_num | Unreviewed
formsets | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by krzysztof.szczesny@…):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
feature added in: #9532
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:1>
Django
Reporter: | Owner: nobody
krzysztof.szczesny@… | Status: new
Type: New feature | Version:
Component: contrib.admin | Resolution:
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 0
Has patch: 0 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by lrekucki):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:2>
Django
Reporter: | Owner: nobody
krzysztof.szczesny@… | Status: new
Type: New feature | Version:
Component: contrib.admin | Resolution:
Keywords: admin min_num | checkin
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by jezdez):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:3>
Django
Reporter: | Owner: nobody
krzysztof.szczesny@… | Status: new
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: admin min_num | checkin
formsets | Needs documentation: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:4>
Django
Reporter: | Owner: nobody
krzysztof.szczesny@… | Status: new
Type: New feature | Version:
Component: contrib.admin | Resolution:
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by claudep):
* stage: Ready for checkin => Accepted
Comment:
This depends on #9532 being committed.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:5>
Django
Reporter: | Owner: tback
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 0
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* owner: nobody => tback
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:6>
Django
Reporter: | Owner: tback
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: timo (added)
* needs_better_patch: 0 => 1
Comment:
I just committed #9532 so this is now unblocked. It would be great to get
this in to 1.7 as well. The patch here needs to be updated -- there's also
a branch from tback on #9532 which addresses some of this.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:7>
Django
Reporter: | Owner: tback
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 1
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: yokomizor (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:8>
Django
Reporter: | Owner: tback
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 1
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: anders@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:9>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Component: contrib.admin | Version:
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by asteinlein):
* owner: tback => asteinlein
Comment:
I updated the patch, see attached 17642-v2.diff or my branch on github:
https://github.com/asteinlein/django/tree/min_num-admin-inline
I would love to get this into 1.7, so I'll be quick to update the patch
after any feedback.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:10>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by timo):
I created a [https://github.com/django/django/pull/2406 pull request] from
the branch and left some comments.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:11>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: stephen.r.burrows@… (added)
Comment:
Just ran into this... it seems like a pretty serious oversight that this
wasn't implemented for model formsets/inline formsets back when the
functionality was introduced in the first place. Would love to see it
fixed. :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:12>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
... and then I noticed that the functionality itself was just added in
1.7.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:13>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by timo):
@melinath, if you would like to update the PR per my comments that will
expedite this getting fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:14>
Django
Reporter: | Owner:
krzysztof.szczesny@… | asteinlein
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin min_num | Triage Stage: Accepted
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
@timo: Yeah... I was hoping asteinlein would pop out of the shadows. :-p
I'm already working on [https://code.djangoproject.com/ticket/22502
another patch for django], and I want to wait until it's done before I
take another one on. Barring a massive influx of free time.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:15>
Django
Reporter: | Owner: melinath
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 1
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
-------------------------------------+-------------------------------------
Changes (by melinath):
* owner: asteinlein => melinath
Comment:
Okay, taking it on.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:16>
Django
Reporter: | Owner: melinath
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 1
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
@timo: I've run into some strange behavior - see my note on #9532. Would
it be reasonable for me to integrate a fix into just the modelformset
behavior, in your opinion?
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:17>
Django
Reporter: | Owner: melinath
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: admin min_num | Needs documentation: 0
formsets | Patch needs improvement: 1
Has patch: 1 | UI/UX: 1
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by timo):
Yes, a separate PR to address that issue would be best.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:18>
Django
Reporter: | Owner: timo
krzysztof.szczesny@… | Status: assigned
Type: New feature | Version:
Component: contrib.admin | Resolution:
Keywords: admin min_num | checkin
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by timo):
* owner: melinath => timo
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
I will give this a final review and merge it tomorrow.
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:19>
Django
Reporter: | Owner: timo
krzysztof.szczesny@… | Status: closed
Type: New feature | Version:
Component: contrib.admin | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: admin min_num | checkin
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2914f66983a92fcae55673c517dd8d01e8c238c4"]:
{{{
#!CommitTicketReference repository=""
revision="2914f66983a92fcae55673c517dd8d01e8c238c4"
[1.7.x] Fixed #17642 -- Added min_num support to modelformsets, inlines,
and the admin.
Thanks Stephen Burrows for work on the patch as well.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:20>
Django
Reporter: | Owner: timo
krzysztof.szczesny@… | Status: closed
Type: New feature | Version:
Component: contrib.admin | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: admin min_num | checkin
formsets | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"4ef10f245ada0c7d5ae8dc31eebffa63790d40fb"]:
{{{
#!CommitTicketReference repository=""
revision="4ef10f245ada0c7d5ae8dc31eebffa63790d40fb"
Fixed #17642 -- Added min_num support to modelformsets, inlines, and the
admin.
Thanks Stephen Burrows for work on the patch as well.
Forwardport of 2914f66983a92fcae55673c517dd8d01e8c238c4 from stable/1.7.x
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:21>
Django
Reporter: | Owner: Tim
krzysztof.szczesny@… | Graham
Type: New feature | Status: closed
Component: contrib.admin | Version:
Severity: Normal | Resolution: fixed
Keywords: admin min_num | Triage Stage: Ready for
formsets | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Comment (by GitHub <noreply@…>):
In [changeset:"13704b057d3c77d9442a150f79d8fad34bcdb995" 13704b0]:
{{{
#!CommitTicketReference repository=""
revision="13704b057d3c77d9442a150f79d8fad34bcdb995"
Refs #17642 -- Doc'd min_num and validate_min arguments in
modelformset_factory() docs.
Changed arguments ordering to match the modelformset_factory()
signature.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:22>
Django
Reporter: | Owner: Tim
krzysztof.szczesny@… | Graham
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: admin min_num | Triage Stage: Ready for
formsets | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"6eb0f4f70d0c785874a616e871dfc9d56a306728" 6eb0f4f7]:
{{{
#!CommitTicketReference repository=""
revision="6eb0f4f70d0c785874a616e871dfc9d56a306728"
[3.1.x] Refs #17642 -- Doc'd min_num and validate_min arguments in
modelformset_factory() docs.
Changed arguments ordering to match the modelformset_factory()
signature.
Backport of 13704b057d3c77d9442a150f79d8fad34bcdb995 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17642#comment:23>