[Django] #18491: When deleting a proxy model, the admin does not show warning about cascade delete for object with foreign key on the proxied model
Django
delete for object with foreign key on the proxied model
-------------------------------+--------------------
Reporter: bdauvergne@… | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Suppose this
{{{
class A(Model):
pass
class ProxyA(A):
class Meta:
proxy = True
class B(Model):
a = ForeignKey(A)
}}}
If you expose ProxyA in the admin/ and try to delete an instance which has
linked B objects, there will be no warning about the cascading delete.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
delete for object with foreign key on the proxied model
Type: Bug | Status: new
Component: contrib.admin | Version: 1.4
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by aaugustin):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Here's the history of bugs related to deletion of proxy models: #18083,
#16128, #12208, #11116.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:1>
Django
delete for object with foreign key on the proxied model
Type: Bug | Status: new
Component: contrib.admin | Version: 1.4
Keywords: | Triage Stage: Accepted
Changes (by akaariai):
* stage: Unreviewed => Accepted
Comment:
I have verified this in HEAD.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:2>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner: gszczepanczyk
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.4
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gszczepanczyk):
* owner: nobody => gszczepanczyk
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:3>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner: gszczepanczyk
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gszczepanczyk):
* has_patch: 0 => 1
Comment:
I have added pull request with fix:
https://github.com/django/django/pull/774
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:4>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: assigned
Severity: Normal | Version: 1.4
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by chomik):
* stage: Accepted => Ready for checkin
Comment:
PR 774 seems ok for me.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:5>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: assigned
Severity: Normal | Version: 1.4
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by gszczepanczyk):
I have pushed recommended solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:6>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Severity: Normal | Version: 1.4
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2b48fcc607010065c0f8107baf669dd41b164f3c"]:
{{{
#!CommitTicketReference repository=""
revision="2b48fcc607010065c0f8107baf669dd41b164f3c"
Fixed #18491 -- deleting a proxy doesn't show warning about cascade
deletes
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:7>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: closed
Severity: Normal | Version: 1.4
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timo):
Fixing this seems to have introduced another regression, see #20777. We
may revert this fix if we can't come up with a solution for that.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:8>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: closed
Severity: Normal | Version: 1.4
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"c769c266017c9a527444f8f026c7a76b394d0412"]:
{{{
#!CommitTicketReference repository=""
revision="c769c266017c9a527444f8f026c7a76b394d0412"
[1.6.x] Revert "Fixed #18491 -- deleting a proxy doesn't show warning
about cascade deletes"
This reverts commit 2b48fcc607010065c0f8107baf669dd41b164f3c.
It introduced a regression (#20777) which we can't easily fix in 1.6.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:9>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: closed
Severity: Normal | Version: 1.4
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timo):
Fix has been reverted in 1.6.x, but will remain in master and removed (but
fixed via a new change) in https://github.com/django/django/pull/1478
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:10>
Django
delete for object with foreign key on the proxied model
Reporter: bdauvergne@… | Owner:
Type: Bug | gszczepanczyk
Component: contrib.admin | Status: closed
Severity: Normal | Version: 1.4
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by akaariai):
Fixed again in 3844089edc43ff29aab5bac82a0eecab23d8d14a - the fix isn't in
1.6.x, only master.
--
Ticket URL: <https://code.djangoproject.com/ticket/18491#comment:11>