[Django] #22464: 1.7b1 tarball missing contrib/gis/static
Django
----------------------------+------------------------
Reporter: michael@… | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: 1.7-beta-1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------
The tar download at https://www.djangoproject.com/download/1.7b1/tarball/
does not contain a django/contrib/gis/static directory.
This is present in the source:
https://github.com/django/django/tree/stable/1.7.x/django/contrib/gis/static/gis/js
Without the JS file contained here, OLMapWidget.js, geospatial fields do
not appear in the admin.
--
Ticket URL: <https://code.djangoproject.com/ticket/22464>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: 1.7-beta-1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bmispelon):
* needs_better_patch: => 0
* needs_docs: => 0
* severity: Normal => Release blocker
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
Hi,
I have no idea why that's happening, but we should definitely fix this for
the final release.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:1>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: 1.7-beta-1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
It's probably `MANIFEST.in` missing the `recursive-include
django/contrib/gis/static *` line. But this line was also absent from the
1.6 release and the js file is still in the 1.6 tarball. Did we change the
packaging method?
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:2>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: 1.7-beta-1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timo):
Yes, we switched to setuptools in
66f546b90624297858b0f958abbe5c2b3e8bdffb.
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:3>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: 1.7-beta-1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by mardini):
For convenience, PR: https://github.com/django/django/pull/2586
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:4>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: closed
Component: Packaging | Version: 1.7-beta-1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Moayad Mardini <moayad.m@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"bad4721b45e0a3e05b6122644e5da41616313ffe"]:
{{{
#!CommitTicketReference repository=""
revision="bad4721b45e0a3e05b6122644e5da41616313ffe"
Fixed #22464 - included contrib/gis/static in tarball
After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be `recursive-include` in `MANIFEST.in`
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:5>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: closed
Component: Packaging | Version: 1.7-beta-1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Alex Gaynor <alex.gaynor@…>):
In [changeset:"f293063c201b9ccc5258fc288b483697461e8116"]:
{{{
#!CommitTicketReference repository=""
revision="f293063c201b9ccc5258fc288b483697461e8116"
Merge pull request #2586 from mmardini/patch-2
Fixed #22464 - included contrib/gis/static in tarball
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:6>
Django
Reporter: michael@… | Owner: nobody
Type: Bug | Status: closed
Component: Packaging | Version: 1.7-beta-1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"bdfa3fd9b3b93ad94e8de7fe3b4c38d395368812"]:
{{{
#!CommitTicketReference repository=""
revision="bdfa3fd9b3b93ad94e8de7fe3b4c38d395368812"
[1.7.x] Fixed #22464 - included contrib/gis/static in tarball
After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be `recursive-include` in `MANIFEST.in`
Backport of bad4721b45 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22464#comment:7>