[Django] #22403: Add AMD support for django javascript object

8 views
Skip to first unread message

Django

unread,
Apr 7, 2014, 3:04:58 PM4/7/14
to django-...@googlegroups.com
#22403: Add AMD support for django javascript object
--------------------------------------+--------------------
Reporter: ian.morrison.a@… | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Translations | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+--------------------
I have been having problems integrating the javasctipt i18n support with a
complex javascript front-end. It would be tremendously useful for the
global 'django' object - that is exported in 'django/views/i18n.py' -
could also be exported as an AMD module.

--
Ticket URL: <https://code.djangoproject.com/ticket/22403>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2014, 5:27:31 PM4/7/14
to django-...@googlegroups.com
#22403: Add AMD support for django javascript object
-------------------------------------+-------------------------------------
Reporter: ian.morrison.a@… | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.6
Component: Translations | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

For what it's worth, the debug toolbar went down this road and it was an
epic failure that still hasn't been resolved. See the two dozen of related
tickets on GitHub for more info. As far as I can tell, supporting AMD
actually means forcing all our users to use AMD.

--
Ticket URL: <https://code.djangoproject.com/ticket/22403#comment:1>

Django

unread,
Apr 8, 2014, 7:54:28 PM4/8/14
to django-...@googlegroups.com
#22403: Add AMD support for django javascript object
-------------------------------------+-------------------------------------
Reporter: ian.morrison.a@… | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: | Resolution:
Internationalization | Triage Stage:
Severity: Normal | Unreviewed
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* version: 1.6 => master
* component: Translations => Internationalization
* easy: 1 => 0


Comment:

https://github.com/django/django/pull/2524

--
Ticket URL: <https://code.djangoproject.com/ticket/22403#comment:2>

Django

unread,
Apr 25, 2014, 10:15:17 AM4/25/14
to django-...@googlegroups.com
#22403: Add AMD support for django javascript object
-------------------------------------+-------------------------------------
Reporter: ian.morrison.a@… | Owner: nobody

Type: | Status: new
Cleanup/optimization | Version: master
Component: | Resolution:
Internationalization | Triage Stage:
Severity: Normal | Unreviewed
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by alejandro):

I tested it with a minimal example and works, the following logs `true` to
the console:

{{{
require(['django'], function(amdDjango) {
console.log(amdDjango === window.django);
});
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22403#comment:3>

Django

unread,
Apr 28, 2014, 7:53:40 PM4/28/14
to django-...@googlegroups.com
#22403: Add AMD support for django javascript object
-------------------------------------+-------------------------------------
Reporter: ian.morrison.a@… | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: | Resolution: wontfix

Internationalization | Triage Stage:
Severity: Normal | Unreviewed
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* status: new => closed
* resolution: => wontfix


Comment:

I noticed that the debug toolbar has [https://github.com/django-debug-
toolbar/django-debug-
toolbar/commit/727b4e05f59c15904f7b08388220b7bfc76d59b2 abandoned the
effort to integrate with AMD]. Not sure of the specifics as I haven't used
AMD, but this seems like something that should first be raised on the
django-developers mailing list in order to determine if it's worth it.

--
Ticket URL: <https://code.djangoproject.com/ticket/22403#comment:4>

Reply all
Reply to author
Forward
0 new messages