[Django] #18460: In admin, the history for model User shows always a change in password, although it is not changed
Django
although it is not changed
--------------------------------+-----------------------------
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.4
Severity: Normal | Keywords: admin, password
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+-----------------------------
Once a user is saved in django admin, and entry in the log is created.
When a field is changed, i.e the username, the history for that user
shows:
"Changed password and username."
It shouldn't show password
--
Ticket URL: <https://code.djangoproject.com/ticket/18460>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
although it is not changed
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: admin, password | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by aaugustin):
* needs_docs: => 0
* needs_better_patch: => 0
* component: Uncategorized => contrib.admin
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
Indeed, this bug is trivial to reproduce. It probably has something to do
with the new password hashing (or it may predate it).
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:1>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: admin, password | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Vaal):
Fix https://github.com/django/django/pull/654
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:2>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:3>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: admin, password | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
It is probably RFC, however, if we commit the patch attached to #16612
(waiting review), the `_has_changed` method will move from widget to
field.
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:4>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.4
Severity: Normal | Resolution: fixed
Keywords: admin, password | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"1686e0d184aaf704e5131a8651a070c4a0e58b03"]:
{{{
#!CommitTicketReference repository=""
revision="1686e0d184aaf704e5131a8651a070c4a0e58b03"
Fixed #18460 -- Fixed change detection of ReadOnlyPasswordHashField
Thanks jose.sanchez et ezeep.com for the report and Vladimir Ulupov
for the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:5>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: admin, password | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by anonymous):
* status: closed => new
* version: 1.4 => 1.5
* resolution: fixed =>
Comment:
I'm still experiencing this issue when using a custom User model. If I
comment out the line:
password = ReadOnlyPasswordHashField()
in my CustomUserChangeForm class, then saves with no changes are correctly
logged with "No fields changed." However, then I'm able to see and edit
the hash. Once the line is back in my code, every save results in a
"Changed password." log entry.
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:6>
Django
although it is not changed
Reporter: jose.sanchez@… | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: admin, password | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* status: new => closed
* resolution: => fixed
Comment:
This was fixed in 1.6, not 1.5 (if you look at the commit, you'll see it
has 1.6 tags). Since you've set "Version" to 1.5, I'm assuming that's the
version you are reporting this against -- please reopen if not. A test
case for Django's test suite would also be extremely helpful if you
believe there's still a bug here.
--
Ticket URL: <https://code.djangoproject.com/ticket/18460#comment:7>