[Django] #19528: CachedFilesMixin does not rewrite rules for css selector with path
Django
--------------------------------+------------------------------------------
Reporter: mike@… | Owner: nobody
Type: Bug | Status: new
Component: | Version: 1.4
contrib.staticfiles | Keywords: CachedFilesMixin staticfiles
Severity: Normal | Has patch: 0
Triage Stage: Unreviewed | UI/UX: 0
Easy pickings: 0 |
--------------------------------+------------------------------------------
Using CachedFilesMixin we'll have paths like this
`<img alt="True" src="/media/static/admin/img/icon-yes.0596085e212f.gif">`
after template rendering, but an unmodified selector:
`img[src$="admin/img/icon-yes.gif"]` in processed stylesheet.
This happens because CachedFilesMixin.patterns does not contain a rule
like this `"""(img\[src[\^\$\*]{0,1}=\s*["']\s*(.*?)["'])"""` to match
against and actually can not deal with `^=|$=|*=` operators. I am not sure
how such paths can be properly processed, though.
--
Ticket URL: <https://code.djangoproject.com/ticket/19528>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: mike@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: CachedFilesMixin | Triage Stage: Accepted
staticfiles | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_docs: => 0
* needs_better_patch: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
Totally out of my expertise area, but seems valid.
--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:1>
Django
Reporter: mike@… | Owner: jnovinger
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 1.4
Severity: Normal | Resolution:
Keywords: CachedFilesMixin | Triage Stage: Accepted
staticfiles |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by jnovinger):
* owner: nobody => jnovinger
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:2>
Django
Reporter: mike@… | Owner: jnovinger
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 1.4
Severity: Normal | Resolution:
Keywords: CachedFilesMixin | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by jnovinger):
* keywords: CachedFilesMixin staticfiles => CachedFilesMixin staticfiles
djbday
--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:3>
Django
Reporter: mike@… | Owner: Jason
| Novinger
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 1.4
Severity: Normal | Resolution: invalid
Keywords: CachedFilesMixin | Triage Stage: Accepted
staticfiles djbday |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => invalid
Comment:
This issue is not valid anymore because `CachedFilesMixin` and
`CachedStaticFilesStorage` will be removed in Django 3.1 (see
f1894bae3071da4ee577fc40ae61491f3e03d82c).
--
Ticket URL: <https://code.djangoproject.com/ticket/19528#comment:4>