Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
------------------------------------+-------------------------------------
Reporter: witek@… | Owner: desh
Type: Bug | Status: assigned
Milestone: | Component: Core (Cache system)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------------
Changes (by desh):

* owner: nobody => desh
* status: new => assigned
* ui_ux: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#15806: Error in filebased cache culling
------------------------------------+-------------------------------------
Reporter: witek@… | Owner: desh
Type: Bug | Status: assigned
Milestone: | Component: Core (Cache system)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:

Triage Stage: Accepted | Has patch: 1

Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------------
Changes (by desh):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:3>

[Django]

#15806: Error in filebased cache culling
------------------------------------+-------------------------------------
Reporter: witek@… | Owner: desh
Type: Bug | Status: assigned
Milestone: | Component: Core (Cache system)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0

Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------------
Changes (by aaugustin):

* needs_better_patch: 0 => 1

Comment:

Could you consolidate the tests and the fix in the same patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:4>

[Django]

#15806: Error in filebased cache culling
------------------------------------+-------------------------------------
Reporter: witek@… | Owner: desh
Type: Bug | Status: assigned
Milestone: | Component: Core (Cache system)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------------

Comment (by desh):

Replying to [comment:4 aaugustin]:

> Could you consolidate the tests and the fix in the same patch?

Yep, sorry for that, just done tests before actually fixing so they came
up first.

You can actually pick the merged_patch.diff from #15825, it contains all
in one, tests and code for #15806 and #15825.

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:5>

[Django]

#15806: Error in filebased cache culling
------------------------------------+-------------------------------------
Reporter: witek@… | Owner: desh
Type: Bug | Status: assigned
Milestone: | Component: Core (Cache system)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0

Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------------
Changes (by desh):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:6>

[Django]

#15806: Error in filebased cache culling

-------------------------------------+------------------------------------
Reporter: witek@… | Owner:
Type: Bug | Status: new

Component: Core (Cache system) | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+------------------------------------
Changes (by desh):

* owner: desh =>
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:7>

[Django]

#15806: Error in filebased cache culling
-------------------------------------+------------------------------------
Reporter: witek@… | Owner:
Type: Bug | Status: new

Component: Core (Cache system) | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------

Changes (by marfire):

* has_patch: 1 => 0
* version: 1.3 => master

Comment:

This is fixed by the solution to #20536.

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:8>

[Django]

#15806: Error in filebased cache culling

-------------------------------------+-------------------------------------
Reporter: witek@… | Owner: Anssi
Type: Bug | Kääriäinen <akaariai@…>
Component: Core (Cache system) | Status: closed
Severity: Normal | Version: master
Keywords: | Resolution: fixed
Has patch: 0 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Anssi Kääriäinen <akaariai@…>):

* owner: => Anssi Kääriäinen <akaariai@…>
* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"7be638390e18fcbfaaed638f9908673360c280d3"]:
{{{
#!CommitTicketReference repository=""
revision="7be638390e18fcbfaaed638f9908673360c280d3"
Fixed #20536 -- rewrite of the file based cache backend

* Safer for use in multiprocess environments
* Better random culling
* Cache files use less disk space
* Safer delete behavior

Also fixed #15806, fixed #15825.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15806#comment:9>