[Django] #21560: missing 'slug' field in example code

7 views
Skip to first unread message

Django

unread,
Dec 4, 2013, 1:52:49 PM12/4/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+--------------------
Reporter: jfindlay@… | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
https://docs.djangoproject.com/en/1.6/topics/forms/modelforms/#overriding-
the-default-fields

Consider the 2nd to last code quotation (before the lengthy 'Note') in
this section. Both the text and the code block refer to and imply a
'slug' field in the fields list of the Meta class. The last code block,
however does not omit it.

--
Ticket URL: <https://code.djangoproject.com/ticket/21560>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 4, 2013, 2:00:10 PM12/4/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+--------------------------------------

Reporter: jfindlay@… | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by jfindlay@…):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Or, maybe it will work the way it is written. I'm confused.

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:1>

Django

unread,
Dec 5, 2013, 7:50:06 AM12/5/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timo):

* type: Uncategorized => Bug
* stage: Unreviewed => Accepted


Comment:

It was an accidental omission.

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:2>

Django

unread,
Dec 9, 2013, 4:54:46 PM12/9/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: merb
Type: Bug | Status: assigned
Component: Documentation | Version: 1.6

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by merb):

* owner: nobody => merb
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:3>

Django

unread,
Dec 9, 2013, 4:59:37 PM12/9/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: merb
Type: Bug | Status: assigned
Component: Documentation | Version: 1.6

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by merb):

* has_patch: 0 => 1


Comment:

I updated the documentation and added a pull request:
https://github.com/django/django/pull/2058

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:4>

Django

unread,
Dec 10, 2013, 4:14:23 AM12/10/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: merb
Type: Bug | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"0873200e7f61315ad375061a3dc6d37b514ff985"]:
{{{
#!CommitTicketReference repository=""
revision="0873200e7f61315ad375061a3dc6d37b514ff985"
Merge pull request #2058 from c-schmitt/fixes_21560

Fixed #21560 -- missing 'slug' field in example code
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:6>

Django

unread,
Dec 10, 2013, 4:14:23 AM12/10/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: merb
Type: Bug | Status: closed
Component: Documentation | Version: 1.6

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Christian Schmitt <c.schmitt@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"744aac6dace325752e3b1c7c8af64a7bc655186f"]:
{{{
#!CommitTicketReference repository=""
revision="744aac6dace325752e3b1c7c8af64a7bc655186f"
Fixed #21560 -- missing 'slug' field in example code
I updated the documentation, that the modelform now includes the 'slug'
field.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:5>

Django

unread,
Dec 10, 2013, 7:27:08 AM12/10/13
to django-...@googlegroups.com
#21560: missing 'slug' field in example code
-------------------------------+------------------------------------
Reporter: jfindlay@… | Owner: merb
Type: Bug | Status: closed
Component: Documentation | Version: 1.6

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"d6d700fc6d5c32b86989a51a8a721e09ca26f1f4"]:
{{{
#!CommitTicketReference repository=""
revision="d6d700fc6d5c32b86989a51a8a721e09ca26f1f4"
[1.6.x] Fixed #21560 -- Added missing 'slug' field in example code.

Backport of 744aac6dac from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21560#comment:7>

Reply all
Reply to author
Forward
0 new messages