Re: [Django] #4960: Add "strip" keyword argument to CharField constructor
Django
-------------------------------------+-------------------------------------
Reporter: tzellman@… | Owner: nobody
Type: Uncategorized | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: CharField strip | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by intgr):
* cc: marti@… (added)
* ui_ux: => 0
* type: => Uncategorized
* severity: => Normal
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: tzellman@… | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
* type: Uncategorized => New feature
* stage: Design decision needed => Accepted
Comment:
Reopening per https://groups.google.com/d/topic/django-
developers/D1GBj9VB9sk/discussion
[https://github.com/django/django/pull/4059 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:6>
Django
---------------------------------+------------------------------------
Reporter: tzellman@… | Owner: nobody
Component: Forms | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):
* status: closed => new
* resolution: wontfix =>
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:7>
Django
---------------------------------+------------------------------------
Reporter: tzellman@… | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:8>
Django
---------------------------------+------------------------------------
Reporter: tzellman@… | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:9>
Django
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by danielward):
* status: new => assigned
* needs_better_patch: 1 => 0
* owner: nobody => danielward
Comment:
Uploading patches with potential solution and follow-up tests. Public
documentation patches can be produced if solution accepted.
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:10>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by danielward):
* Attachment "potential-solution.patch" added.
Potential solution by adding in 'strip' option to CharField
--
Ticket URL: <https://code.djangoproject.com/ticket/4960>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by danielward):
* Attachment "after.patch" added.
Follow-up tests
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by danielward):
* Attachment "potential-solution.patch" added.
Potential solution by adding in 'strip' option to CharField
--
Django
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
* needs_better_patch: 0 => 1
Comment:
I guess you missed the more extensive
[https://github.com/django/django/pull/4059 pull request] that was already
proposed. It still needs some improvements.
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:11>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:12>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"11cac1bd8ef7546ca32d9969d4348bf412dc6664" 11cac1b]:
{{{
#!CommitTicketReference repository=""
revision="11cac1bd8ef7546ca32d9969d4348bf412dc6664"
Fixed #4960 -- Added "strip" option to CharField
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:13>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by guettli):
Thank you very much. I will use the "strip" option in most of my fields.
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:14>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"e7c6a2cf9f37210ed4f784691e44389f38f96d80" e7c6a2cf]:
{{{
#!CommitTicketReference repository=""
revision="e7c6a2cf9f37210ed4f784691e44389f38f96d80"
Refs #4960 -- Fixed selenium test failures for CharField strip changes.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:15>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by lamby):
Should the default really be "True"? Somewhat backward incompatibile /
unexpected change.
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:16>
Django
---------------------------------+--------------------------------------
Reporter: tzellman@… | Owner: danielward
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: CharField strip | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by timgraham):
That was the conclusion of the django-developers thread linked in comment
6. Feel free to raise the issue there if you disagree.
--
Ticket URL: <https://code.djangoproject.com/ticket/4960#comment:17>