Re: [Django] #12008: included templates' blocks do not get processed as if they were from the context of the including page

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: include block | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by mcgeeco):

* status: new => assigned
* owner: nobody => mcgeeco

Comment:

I would like to try to fix this. I think the confusion has been mostly
resolved in the newer documentation, as far as I can see
[https://docs.djangoproject.com/en/dev/ref/templates/builtins/#include
here] in the 'note'. I think it would be useful to add a version of
russellm's clarification regarding blocks, as they are currently not
mentioned. Would an example also be necessary?

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: include block | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by mcgeeco):

Made pull request [https://github.com/django/django/pull/3360 here].

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:8>

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: include block | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by mcgeeco):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:9>

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: include block | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by mcgeeco):

Made updated pull request with the wording suggested by evildmp, which I
agree does a better job of explaining the process.

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:10>

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco

Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: include block | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"80b8d3bee035b56b0d9ac57dd732dffa3b2d5f3c"]:
{{{
#!CommitTicketReference repository=""
revision="80b8d3bee035b56b0d9ac57dd732dffa3b2d5f3c"
Fixed #12008 -- Clarified relationship between template blocks and
includes.

Thanks Daniele Procida for suggested wording.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:11>

[Django]

#12008: included templates' blocks do not get processed as if they were from the
context of the including page
--------------------------------------+------------------------------------
Reporter: tim@… | Owner: mcgeeco
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: include block | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"b729ef0bda5009389da7e3a5498dc1f6233761d6"]:
{{{
#!CommitTicketReference repository=""
revision="b729ef0bda5009389da7e3a5498dc1f6233761d6"
[1.7.x] Fixed #12008 -- Clarified relationship between template blocks and
includes.

Thanks Daniele Procida for suggested wording.

Backport of 80b8d3bee0 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/12008#comment:12>