[Django] #22801: Broken link on Django settings page

29 views
Skip to first unread message

Django

unread,
Jun 10, 2014, 10:34:26 AM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+--------------------
Reporter: amkeller@… | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Broken link on Django settings page
https://docs.djangoproject.com/en/1.4/topics/settings/.

The last 4 words in the sentence "Note that the settings module should be
on the Python import search path" are linked to the following page:

http://diveintopython.net/getting_to_know_python/everything_is_an_object.html

This link doesn't work and takes you to the diveintopython.net home page.

The correct link has a "www" prepended to the domain name:

http://www.diveintopython.net/getting_to_know_python/everything_is_an_object.html

I noticed this when the link to the same page on Stack Overflow worked but
yous didn't. Stack overflow page with working link:
http://stackoverflow.com/questions/865911/is-everything-an-object-in-
python-like-ruby

Another question: is this even the right link from that text?

--
Ticket URL: <https://code.djangoproject.com/ticket/22801>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 10, 2014, 10:45:12 AM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------

Reporter: amkeller@… | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by bmispelon):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* easy: 0 => 1
* stage: Unreviewed => Accepted


Comment:

Hi,

It seems that the redirection in place on diveintopython.net (redirecting
diveintopython.net to www.diveintopython.net) is broken and drops the
whole path from the URL.

That's probably something which should be reported to them, but in the
meantime, it should be enough for us to add the `www.` to all links
pointing there in our documentation (there are a few which you can find by
doing `git grep diveintopython.net`).


As for whether this is the correct link to point to, I believe it is: that
section explains what the import search path is.

Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:1>

Django

unread,
Jun 10, 2014, 2:05:32 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: assigned
Component: Documentation | Version: 1.6

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by maxocub):

* status: new => assigned
* owner: nobody => maxocub


--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:2>

Django

unread,
Jun 10, 2014, 3:02:25 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: assigned
Component: Documentation | Version: 1.6

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by maxocub):

* has_patch: 0 => 1


Comment:

Here's my [https://github.com/django/django/pull/2792 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:3>

Django

unread,
Jun 10, 2014, 3:20:59 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: assigned
Component: Documentation | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by maxocub):

* version: 1.6 => master


Comment:

Here's the right [https://github.com/django/django/pull/2793 PR]

I'm not sure I'm allowed to do that, but I changed the version to master,
but it should be backported to other versions.

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:4>

Django

unread,
Jun 10, 2014, 3:39:15 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"f97c53c0989336563c535c9737dff197b403054d"]:
{{{
#!CommitTicketReference repository=""
revision="f97c53c0989336563c535c9737dff197b403054d"
Fixed #22801 -- Added 'www.' to diveintopython.net links
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:5>

Django

unread,
Jun 10, 2014, 3:42:08 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"de0e285be80e0ca756088a97335d8faa698fbe6b"]:
{{{
#!CommitTicketReference repository=""
revision="de0e285be80e0ca756088a97335d8faa698fbe6b"
[1.7.x] Fixed #22801 -- Added 'www.' to diveintopython.net links

Backport of f97c53c098 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:6>

Django

unread,
Jun 10, 2014, 3:42:09 PM6/10/14
to django-...@googlegroups.com
#22801: Broken link on Django settings page
-------------------------------+------------------------------------
Reporter: amkeller@… | Owner: maxocub
Type: Uncategorized | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"fcd2e06ae5110fe6327128e8d170302c20077988"]:
{{{
#!CommitTicketReference repository=""
revision="fcd2e06ae5110fe6327128e8d170302c20077988"
[1.6.x] Fixed #22801 -- Added 'www.' to diveintopython.net links

Backport of f97c53c098 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22801#comment:7>

Reply all
Reply to author
Forward
0 new messages