Re: [Django] #5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for different fields

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: SplitDateTimeWidget
Resolution: | MultiWidget
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by jacob):

* ui_ux: => 0
* easy: => 0
* stage: Design decision needed => Accepted

Comment:

The first solution (making the fix to `MultiWidget`) is the right way to
go.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: SplitDateTimeWidget
Resolution: | MultiWidget
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------

Comment (by julien):

#14718 was closed as duplicate. See also #16754 for a related issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:6>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: SplitDateTimeWidget
Resolution: | MultiWidget
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------

Comment (by julien):

#10343 was also closed as dupe.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:7>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: SplitDateTimeWidget
Resolution: | MultiWidget
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------

Comment (by jacob):

And other: #16754.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:8>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: SplitDateTimeWidget
Resolution: | MultiWidget
Triage Stage: Accepted | Has patch: 1

Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by kmike):

* cc: kmike84@… (added)
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:9>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody

Type: New feature | Status: new
Component: Forms | Version: SVN
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by koenb):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 0 => 1

Comment:

Attaching a patch that allows passing a list of attrs into the multiwidget
(first approach).

Includes some simple tests.

No documentation yet.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:10>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New feature | Status: new

Component: Forms | Version: master

Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by charettes):

* cc: charette.s@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:11>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget |

Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by jameskirsop):

* cc: james.kirsop@… (added)

Comment:

Would love to see this reviewed at some stage. It would be particularly
helpful in supporting the "placeholder" attribute.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:12>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by claudep):

Before this is reviewed, we should have a pull request with the proposed
patch, including tests and docs.

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:13>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------

Reporter: ciantic@… | Owner: felixxm
Type: New feature | Status: assigned

Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* status: new => assigned
* needs_docs: 1 => 0
* owner: nobody => felixxm
* cc: felisiak.mariusz@… (added)

Comment:

I think that this is a issue specific for `SplitDateTimeWidget` and
`SplitHiddenDateTimeWidget`, because in general you can get the same
result in a different way e.g.:

{{{
MultiWidget(
widgets=(
Input(attrs={'class': 'foo'}),
Input(attrs={'class': 'bar'}),
)
)
}}}

IMO there is no need to complicate `MultiWidget`.

[https://github.com/django/django/pull/7843 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:14>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: felixxm
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:15>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: felixxm
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: SplitDateTimeWidget | Triage Stage: Accepted
MultiWidget |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:16>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: felixxm
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:

Keywords: SplitDateTimeWidget | Triage Stage: Ready for
MultiWidget | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:17>

[Django]

#5851: SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for
different fields
-------------------------------------+-------------------------------------
Reporter: ciantic@… | Owner: felixxm

Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: SplitDateTimeWidget | Triage Stage: Ready for
MultiWidget | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"0034e9af18f3d393a6dd2389ffbba4c919b1d7d7" 0034e9a]:
{{{
#!CommitTicketReference repository=""
revision="0034e9af18f3d393a6dd2389ffbba4c919b1d7d7"
Fixed #5851 -- Allowed specifying different HTML attrs for
SplitDateTimeWidget subwidgets.

Thanks Tim Graham and Nick Pope for review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/5851#comment:18>