[Django] #27945: RegexValidator uses search instead of match
Django
-----------------------------------------+------------------------
Reporter: Shubham Jain | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The documentation says, RegexValidator matches the regex against the
value, and hence ideally it must use regex.match but instead uses
regex.search.
This looks like a bug.
--
Ticket URL: <https://code.djangoproject.com/ticket/27945>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Shubham Jain | Owner: nobody
Component: Core (Other) | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
Changes (by Shubham Jain):
* type: Uncategorized => Bug
* has_patch: 0 => 1
* component: Uncategorized => Core (Other)
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:1>
Django
Reporter: Shubham Jain | Owner: nobody
Component: Core (Other) | Version: 1.10
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
Comment (by Tim Graham):
Where's the documentation you quoted?
[https://docs.djangoproject.com/en/dev/ref/validators/#django.core.validators.RegexValidator.regex
I see], "The regular expression pattern to search for the provided value".
Presumably the documentation you mentioned should be fixed since changing
behavior would be backwards incompatible.
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:2>
Django
Reporter: Shubham Jain | Owner: nobody
Component: Core (Other) | Version: 1.10
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
Comment (by Shubham Jain):
So the
[documentation](https://docs.djangoproject.com/en/dev/ref/validators/#django.core.validators.RegexValidator.regex)
says, "regex pattern to search for provided value". I suppose this means,
you try to see if value fits in the regex. But instead it sees if regex
fits anywhere in the value. So in documentation, it must be "regex pattern
to search for, in the provided value".
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:3>
Django
--------------------------------------+------------------------------------
Reporter: Shubham Jain | Owner: nobody
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):
* type: Bug => Cleanup/optimization
* has_patch: 1 => 0
* stage: Unreviewed => Accepted
* component: Core (Other) => Documentation
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:4>
Django
Reporter: Shubham Jain | Owner: Sean
Type: | Fagan
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Sean Fagan):
* status: new => assigned
* owner: nobody => Sean Fagan
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Shubham Jain | Owner: Sean
Type: | Fagan
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Sean Fagan):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/8203 Pull Request] added
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Shubham Jain | Owner: Sean
Type: | Fagan
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"325db2a8c3453a56db5e0df0eed37476eb67802d" 325db2a8]:
{{{
#!CommitTicketReference repository=""
revision="325db2a8c3453a56db5e0df0eed37476eb67802d"
Fixed #27945 -- Clarified that RegexValidator searches with the regex.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Shubham Jain | Owner: Sean
Type: | Fagan
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"b406c3ea2889b386efc5d97999ff1de3c2ddf128" b406c3ea]:
{{{
#!CommitTicketReference repository=""
revision="b406c3ea2889b386efc5d97999ff1de3c2ddf128"
[1.11.x] Fixed #27945 -- Clarified that RegexValidator searches with the
regex.
Backport of 325db2a8c3453a56db5e0df0eed37476eb67802d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27945#comment:8>