[Django] #25658: Add an optional positional argument to inspectdb to allow choosing what table/views should be inspected

8 views
Skip to first unread message

Django

unread,
Nov 1, 2015, 7:02:58 PM11/1/15
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
----------------------------------------------+-----------------------
Reporter: JoseTomasTocino | Owner: nobody
Type: New feature | Status: new
Component: Database layer (models, ORM) | Version: 1.8
Severity: Normal | Keywords: inspectdb
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+-----------------------
Comes from this discussion: https://groups.google.com/forum/#!topic
/django-developers/CuczZovhp74

It would be great to be able to manually choose what table and/or views
should be inspected when using the `inspectdb` command, specially in
situations where readable table/views are not properly reported by the DB.

Here's a pull request with my proposed solution:
https://github.com/django/django/pull/5530

--
Ticket URL: <https://code.djangoproject.com/ticket/25658>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 1, 2015, 7:19:08 PM11/1/15
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:

Keywords: inspectdb | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JoseTomasTocino):

* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => JoseTomasTocino
* needs_docs: => 0
* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:1>

Django

unread,
Nov 2, 2015, 3:19:50 AM11/2/15
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: inspectdb | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* needs_docs: 0 => 1
* version: 1.8 => master
* component: Database layer (models, ORM) => Core (Management commands)
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:2>

Django

unread,
Nov 2, 2015, 6:14:42 AM11/2/15
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: inspectdb | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JoseTomasTocino):

* needs_docs: 1 => 0


Comment:

Added docs and release notes in the pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:3>

Django

unread,
Feb 25, 2016, 1:45:59 PM2/25/16
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: wontfix

Keywords: inspectdb | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: assigned => closed
* resolution: => wontfix


Comment:

I think #14098 should solve this use case. Tables which can't be
introspected will now be skipped.

--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:4>

Django

unread,
Feb 25, 2016, 6:42:05 PM2/25/16
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: new
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: inspectdb | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: closed => new
* resolution: wontfix =>


Comment:

Now I realized the problem isn't that the table can't be introspected but
that it's not returned by the existing introspection query on Oracle. So
we either need to revise that query or accept this feature.

--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:5>

Django

unread,
Mar 18, 2016, 8:59:56 AM3/18/16
to django-...@googlegroups.com
#25658: Add an optional positional argument to inspectdb to allow choosing what
table/views should be inspected
-------------------------------------+-------------------------------------
Reporter: JoseTomasTocino | Owner:
| JoseTomasTocino
Type: New feature | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: inspectdb | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"39a16dd2e003f9ca82a6d061a022ced6904bd243" 39a16dd]:
{{{
#!CommitTicketReference repository=""
revision="39a16dd2e003f9ca82a6d061a022ced6904bd243"
Fixed #25658 -- Allowed inspectdb to inspect a specific set of tables.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25658#comment:6>

Reply all
Reply to author
Forward
0 new messages