--
Ticket URL: <https://code.djangoproject.com/ticket/28996>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* Attachment "bool_continue.patch" added.
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
* component: Uncategorized => Core (Other)
Comment:
The patch has a number of syntax errors and flake8 warnings. Can you
please check that and ideally, also run the tests? (If you can submit the
patch as a pull request, those checks would be automated.)
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:1>
* Attachment "bool_continue.patch" added.
Comment (by Tim Graham):
Test failure:
{{{
======================================================================
FAIL: test_render_int
(forms_tests.widget_tests.test_checkboxinput.CheckboxInputTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 59, in
testPartExecutor
yield
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 605, in run
testMethod()
File
"/home/tim/code/django/tests/forms_tests/widget_tests/test_checkboxinput.py",
line 40, in test_render_int
html='<input checked type="checkbox" name="is_cool" value="0" />',
File "/home/tim/code/django/tests/forms_tests/widget_tests/base.py",
line 25, in check_html
assertEqual(output.replace('"', '"'), html)
File "/home/tim/code/django/django/test/testcases.py", line 680, in
assertHTMLEqual
self.fail(self._formatMessage(msg, standardMsg))
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 670, in
fail
raise self.failureException(msg)
AssertionError: <input name="is_cool" type="checkbox" /> != <input checked
name="is_cool" type="checkbox" value="0" />
- <input name="is_cool" type="checkbox" />
+ <input checked name="is_cool" type="checkbox" value="0" />
? ++++++++ ++++++++++
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:2>
* Attachment "bool_continue.patch" added.
* owner: nobody => Priyansh Saxena
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:3>
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
[https://github.com/django/django/pull/9578 PR] from the patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:4>
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a38ae914d89809aed6d79337b74a8b31b6d3849a" a38ae91]:
{{{
#!CommitTicketReference repository=""
revision="a38ae914d89809aed6d79337b74a8b31b6d3849a"
Fixed #28996 -- Simplified some boolean constructs and removed trivial
continue statements.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:5>