[Django] #20767: preserve_filters with namespaces and multiple admins
Django
--------------------------------+------------------------
Reporter: CollinAnderson | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.6-beta-1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------
I'm finding that preserve_filters is not working if I add a second admin
with a namespace.
I have simple multiple admin project that you can use to use to try it
yourself.
https://github.com/collinanderson/multiadmin
I think the problem is happening somewhere around here:
https://github.com/django/django/commit/c86a9b63984f6692d478f6f70e3c78de4ec41814#L0R769
--
Ticket URL: <https://code.djangoproject.com/ticket/20767>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.6-beta-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by loic84):
* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => loic84
* needs_docs: => 0
* stage: Unreviewed => Accepted
Comment:
Thanks for the report and ticket, I can reproduce it.
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:1>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by CollinAnderson):
* cc: cmawebsite@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:2>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by loic84):
PR https://github.com/django/django/pull/1373
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:3>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by loic84):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:4>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by CollinAnderson):
This fixes my problem. Thanks so much.
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:5>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: assigned
Component: contrib.admin | Version:
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by loic84):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:6>
Django
Reporter: CollinAnderson | Owner: loic84
Component: contrib.admin | Version:
Severity: Normal | 1.6-beta-1
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2fc6c9472cd25910f978fe1d18de5c350370f901"]:
{{{
#!CommitTicketReference repository=""
revision="2fc6c9472cd25910f978fe1d18de5c350370f901"
Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs.
Thanks Collin Anderson for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:7>
Django
Reporter: CollinAnderson | Owner: loic84
Type: Bug | Status: closed
Component: contrib.admin | Version:
Severity: Normal | 1.6-beta-1
Keywords: | Resolution: fixed
Has patch: 1 | Triage Stage: Ready for
Needs tests: 0 | checkin
Easy pickings: 0 | Needs documentation: 0
| Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette <charette.s@…>):
In [changeset:"c660f0e9857e570628e68fa856cc0b613382bd1a"]:
{{{
#!CommitTicketReference repository=""
revision="c660f0e9857e570628e68fa856cc0b613382bd1a"
[1.6.x] Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced
URLs.
Thanks Collin Anderson for the report.
Backport of 2fc6c9472c from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20767#comment:8>