[Django] #30768: django.forms.boundfield.as_widget method hasn't been updated, and causes an exception when used!

[Django]

#30768: django.forms.boundfield.as_widget method hasn't been updated, and causes an
exception when used!
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
chefables-mark |
Type: Bug | Status: new
Component: Forms | Version: 2.2
Severity: Normal | Keywords: boundfiled renderer
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
/django/forms/boundfield.py;90-95 calls widget.render() with
'rederer=self.form.renderer' on line 94

the renderer argument was removed in 2.1;
<https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
in-2-1>

This should be very easy to fix; it looks like this method wasn't updated
when the renderer argument was removed.

I commented out line 94 locally and it fixes the problem.

I just installed 2.2.5 to verify that this still existed, I also did a
search of existing tickets, but couldn't find this reported yet.

--
Ticket URL: <https://code.djangoproject.com/ticket/30768>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#30768: django.forms.boundfield.as_widget method hasn't been updated, and causes an
exception when used!
-------------------------------------+-------------------------------------

Reporter: chefables-mark | Owner: nobody

Type: Bug | Status: new
Component: Forms | Version: 2.2

Severity: Normal | Resolution:

Keywords: boundfiled renderer | Triage Stage:

| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by chefables-mark):

* Attachment "boundfield.py.diff" added.

[Django]

#30768: django.forms.boundfield.as_widget method hasn't been updated, and causes an
exception when used!
-------------------------------------+-------------------------------------

Reporter: Mark | Owner: nobody

Type: Bug | Status: new
Component: Forms | Version: 2.2

Severity: Normal | Resolution:

Keywords: boundfiled renderer | Triage Stage:

| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Mark:

Old description:

> /django/forms/boundfield.py;90-95 calls widget.render() with
> 'rederer=self.form.renderer' on line 94
>
> the renderer argument was removed in 2.1;
> <https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
> in-2-1>
>
> This should be very easy to fix; it looks like this method wasn't updated
> when the renderer argument was removed.
>
> I commented out line 94 locally and it fixes the problem.
>
> I just installed 2.2.5 to verify that this still existed, I also did a
> search of existing tickets, but couldn't find this reported yet.

New description:

/django/forms/boundfield.py;90-95 calls widget.render() with
'rederer=self.form.renderer' on line 94

the renderer argument was removed in 2.1;
<https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
in-2-1>

This should be very easy to fix; it looks like this method wasn't updated
when the renderer argument was removed.

I commented out line 94 locally and it fixes the problem.

I just installed 2.2.5 to verify that this still existed, I also did a
search of existing tickets, but couldn't find this reported yet.

edit: I just rechecked the patch submission guidlines, and I made the
patch wrong, its just the output of 'diff boundfield.py oldboundfield.py';
its simply deleting line 94

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30768#comment:1>

[Django]

#30768: django.forms.boundfield.as_widget() causes an exception when used.

-------------------------------------+-------------------------------------
Reporter: Mark | Owner: nobody

Type: Bug | Status: closed
Component: Forms | Version: 2.2
Severity: Normal | Resolution: invalid

Keywords: boundfiled renderer | Triage Stage:

| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* status: new => closed
* resolution: => invalid

Comment:

`renderer` argument wasn't removed in Django 2.1, we only removed only
support for `Widget.render()` methods **without** this argument. I don't
see any issue in this code.

--
Ticket URL: <https://code.djangoproject.com/ticket/30768#comment:2>