[Django] #25689: Merge staticfiles into core
Django
--------------------------------------+--------------------
Reporter: collinanderson | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.staticfiles | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
(James Aylett on stage at duth)
If you accidentally use {% load static %} instead of {% load staticfiles
%} you won't take advantage of storage engines. However, 3rd-party apps
won't know if the staticfiles library is installed or not.
One solution he mentioned is having {% load static %} match the behavior
of {% load admin_static %} (where it uses staticfiles only if it's
installed), but that would probably involve core importing code from
contrib (usually a no-no).
Another option he gave was merging staticfiles into core. He thought it
might be contentious, but I think is actually a better idea.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by collinanderson):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
We could leave `HashedFilesMixin`, `ManifestFilesMixin`, etc in contrib,
but at least make sure the template tag works correctly. People can
reference `ManifestFilesMixin` in their settings files if they want to use
it.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:1>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Someday/Maybe
Comment:
How about a discussion on the mailing list first? :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:2>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
See also #21221
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:3>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by collinanderson):
actually, I do prefer the approach in #21221, as long as we're ok with a
contrib import from core.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:4>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
I'm sad to import contrib in core but perhaps that's the pragmatic thing.
Count me as a -1.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:5>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
Err I meant a -0. Great typo there.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:6>
Django
Reporter: collinanderson | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Someday/Maybe
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by collinanderson):
* status: new => closed
* cc: cmawebsite@… (added)
* resolution: => wontfix
Comment:
I'll wontfix this assuming #21221 moves through smoothly.
--
Ticket URL: <https://code.djangoproject.com/ticket/25689#comment:7>