[Django] #26693: RenameModel causes state.apps rendering leading to massive time increase in makemigrations
Django
makemigrations
--------------------------------+--------------------
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------
Not 100% sure I have complete understanding of what happens, or why, but
it seems a `RenameModel` migration leads to an evaluation of `state.apps`,
which affects the time it takes for it and all following migration states
to be calculated.
This is for a pretty big app, with lots of migrations. The time to run
`makemigrations` for all apps goes from 1 seconds to 77 seconds with one
`RenameModel` migration.
A test where `apps.state` was replaced by `temp_state = state.close();
apps = temp_state.apps` resolved the issue, but I'm not completely sure of
the side effects of doing that.
--
Ticket URL: <https://code.djangoproject.com/ticket/26693>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by simonpercivall):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> Not 100% sure I have complete understanding of what happens, or why, but
> it seems a `RenameModel` migration leads to an evaluation of
> `state.apps`, which affects the time it takes for it and all following
> migration states to be calculated.
>
> This is for a pretty big app, with lots of migrations. The time to run
> `makemigrations` for all apps goes from 1 seconds to 77 seconds with one
> `RenameModel` migration.
>
> A test where `apps.state` was replaced by `temp_state = state.close();
> apps = temp_state.apps` resolved the issue, but I'm not completely sure
> of the side effects of doing that.
New description:
Not 100% sure I have complete understanding of what happens, or why, but
it seems a `RenameModel` migration leads to an evaluation of `state.apps`,
which affects the time it takes for it and all following migration states
to be calculated.
This is for a pretty big app, with lots of migrations. The time to run
`makemigrations` for all apps goes from 1 seconds to 77 seconds with one
`RenameModel` migration.
A test where `apps.state` was replaced by `temp_state = state.close();
apps = temp_state.apps` resolved the issue, but I'm not completely sure of
the side effects of doing that. (Or even better if it were possible to
check immediately if `'apps' in state.__dict__` and skip the rendering
completely.)
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:1>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
This might be related to #24067.
Could you try disconnecting the
`django.contrib.contenttypes.management.inject_rename_contenttypes_operations`
receiver from the `pre_migrate` signals and see if it solves your issue.
The receiver is connected in
`django.contrib.contenttypes.apps.ContentTypesConfig.ready()`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:2>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
Actually this might not be related at all as #24067 should only affects
`migrate` (not `makemigrations`).
Could you try bisecting the commit that introduced this slow down? Did you
notice it when upgrading from a specific version of Django to another?
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:3>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by simonpercivall):
Well, no, it's the first `RenameModel` in our project, so I haven't seen
it before.
What I do see, to be more specific, is that, timing each
`self.nodes[node].mutate_state(...)` call in `MigrationGraph.make_state`,
each iteration is ~0.01ms. If I add a `RenameModel`, it clocks in at ~1
second, and ''every'' `mutate_state` after that is >0.5 seconds, because,
like I said, `state.apps` has been evaluated and set.
It looks to be the same in Django 1.8 (i.e. things don't get expensive
until `state.apps` has been evaluated once, since most of the state
operations are no-ops if not `'apps' in self.__dict__`).
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:4>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by MarkusH):
It might be related to
https://github.com/django/django/blob/master/django/db/migrations/state.py#L53
but haven't tried it. If it is, I'm afraid there's no solution to it
except for squashing the migrations in that app (possibly manually).
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:5>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by simonpercivall):
A `RemoveModel` and `CreateModel` combo (which in my mind seems like they
should have an equivalent effect on the state as a `RenameModel`) does not
have the same problem.
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:6>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
In the event this can't be fixed, perhaps we can reclassify as a
documentation issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:7>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Migrations | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by heindshed):
* status: new => closed
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* resolution: => fixed
Old description:
> Not 100% sure I have complete understanding of what happens, or why, but
> it seems a `RenameModel` migration leads to an evaluation of
> `state.apps`, which affects the time it takes for it and all following
> migration states to be calculated.
>
> This is for a pretty big app, with lots of migrations. The time to run
> `makemigrations` for all apps goes from 1 seconds to 77 seconds with one
> `RenameModel` migration.
>
> A test where `apps.state` was replaced by `temp_state = state.close();
> apps = temp_state.apps` resolved the issue, but I'm not completely sure
> of the side effects of doing that. (Or even better if it were possible to
> check immediately if `'apps' in state.__dict__` and skip the rendering
> completely.)
New description:
RAraMcÅfË€ JUST CALL NOW zoho phone number 1-888-633-5526 Email tech
1-888-633-5526 nical Support Customer Phone Number
zoho phone number 1-888-633-5526 mail tech 1-888-633-5526 support
zoho phone number 1-888-633-5526 customer service number
zoho phone number 1-888-633-5526 mail tech 1-888-633-5526 support
telephone number
zoho phone number 1-888-633-5526 email Helpline Number
zoho phone number 1-888-633-5526 mail customer support
zoho phone number 1-888-633-5526 mail toll free support number
zoho phone number 1-888-633-5526 email customer service phone number
tech 1-888-633-5526 support numbers for zoho phone number
1-888-633-5526 email
zoho phone number 1-888-633-5526 email customer support number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support number
zoho phone number 1-888-633-5526 email support telephone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support phone number
zoho phone number 1-888-633-5526 mail customer support numbers
zoho phone number 1-888-633-5526 email support number
zoho phone number 1-888-633-5526 email customer support phone number
usa
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
phone number
zoho phone number 1-888-633-5526 email phone tech 1-888-633-5526
support
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
phone numbers
zoho phone number 1-888-633-5526 email free tech 1-888-633-5526
support phone number
zoho phone number 1-888-633-5526 email live mail tech 1-888-633-5526
support
zoho phone number 1-888-633-5526 email live tech 1-888-633-5526
support
zoho phone number 1-888-633-5526 email live chat tech 1-888-633-5526
support
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
live
zoho phone number 1-888-633-5526 email live support
zoho phone number 1-888-633-5526 email live customer support
zoho phone number 1-888-633-5526 mail free customer service number usa
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support
zoho phone number 1-888-633-5526 email support usa
zoho phone number 1-888-633-5526 email helpdesk number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
helpdesk number
zoho phone number 1-888-633-5526 email helpdesk contact number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
services
zoho phone number 1-888-633-5526 email customer support service
zoho phone number 1-888-633-5526 email customer support services usa
zoho phone number 1-888-633-5526 email toll free service
zoho phone number 1-888-633-5526 email toll free customer service
zoho phone number 1-888-633-5526 email customer service desk
zoho phone number 1-888-633-5526 email help desk services
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support usa
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
live chat
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
telephone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support phone
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support chat
zoho phone number 1-888-633-5526 email support phone number usa
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support phone number usa
zoho phone number 1-888-633-5526 email customer support phone number
zoho phone number 1-888-633-5526 email customer support live chat
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
contact number
zoho phone number 1-888-633-5526 email customer service number
zoho phone number 1-888-633-5526 email customer service help
zoho phone number 1-888-633-5526 email customer service usa
zoho phone number 1-888-633-5526 email customer service telephone
number
contact zoho phone number 1-888-633-5526 email customer service
contact zoho phone number 1-888-633-5526 email by phone
how can i contact yahoo about my email account
free zoho phone number 1-888-633-5526 email tech 1-888-633-5526
support phone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support telephone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support contact
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support live chat
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support toll free number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
phone number usa
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support contact number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
toll free number
zoho phone number 1-888-633-5526 email customer support toll free
number
zoho phone number 1-888-633-5526 mail tech support
zoho phone number 1-888-633-5526 customer service number
zoho phone number 1-888-633-5526 mail tech support telephone number
zoho phone number 1-888-633-5526 email Helpline Number
zoho phone number 1-888-633-5526 mail customer support
zoho phone number 1-888-633-5526 mail toll free support number
zoho phone number 1-888-633-5526 email customer service phone number
tech support numbers for zoho phone number 1-888-633-5526 email
zoho phone number 1-888-633-5526 email customer support number
zoho phone number 1-888-633-5526 email technical support number
zoho phone number 1-888-633-5526 email support telephone number
zoho phone number 1-888-633-5526 email technical support phone number
zoho phone number 1-888-633-5526 mail customer support numbers
zoho phone number 1-888-633-5526 email support number
zoho phone number 1-888-633-5526 email customer support phone number
usa
zoho phone number 1-888-633-5526 email tech support phone number
zoho phone number 1-888-633-5526 email phone tech support
zoho phone number 1-888-633-5526 email tech support phone numbers
zoho phone number 1-888-633-5526 email free tech support phone number
zoho phone number 1-888-633-5526 email live mail tech support
zoho phone number 1-888-633-5526 email live tech support
zoho phone number 1-888-633-5526 email live chat tech support
zoho phone number 1-888-633-5526 email tech support live
zoho phone number 1-888-633-5526 email live support
zoho phone number 1-888-633-5526 email live customer support
zoho phone number 1-888-633-5526 mail free customer service number usa
zoho phone number 1-888-633-5526 email technical support
zoho phone number 1-888-633-5526 email support usa
zoho phone number 1-888-633-5526 email helpdesk number
zoho phone number 1-888-633-5526 email tech support helpdesk number
zoho phone number 1-888-633-5526 email helpdesk contact number
zoho phone number 1-888-633-5526 email tech support services
zoho phone number 1-888-633-5526 email customer support service
zoho phone number 1-888-633-5526 email customer support services usa
zoho phone number 1-888-633-5526 email toll free service
zoho phone number 1-888-633-5526 email toll free customer service
zoho phone number 1-888-633-5526 email customer service desk
zoho phone number 1-888-633-5526 email help desk services
zoho phone number 1-888-633-5526 email technical support usa
zoho phone number 1-888-633-5526 email tech support live chat
zoho phone number 1-888-633-5526 email tech support telephone number
zoho phone number 1-888-633-5526 email technical support phone
zoho phone number 1-888-633-5526 email technical support chat
zoho phone number 1-888-633-5526 email support phone number usa
zoho phone number 1-888-633-5526 email technical support phone number
usa
zoho phone number 1-888-633-5526 email customer support phone number
zoho phone number 1-888-633-5526 email customer support live chat
zoho phone number 1-888-633-5526 email tech support contact number
zoho phone number 1-888-633-5526 email customer service number
zoho phone number 1-888-633-5526 email customer service help
zoho phone number 1-888-633-5526 email customer service usa
zoho phone number 1-888-633-5526 email customer service telephone
number
contact zoho phone number 1-888-633-5526 email customer service
contact zoho phone number 1-888-633-5526 email by phone
how can i contact yahoo about my email account
free zoho phone number 1-888-633-5526 email tech support phone number
zoho phone number 1-888-633-5526 email technical support telephone
number
zoho phone number 1-888-633-5526 email technical support contact
zoho phone number 1-888-633-5526 email technical support live chat
zoho phone number 1-888-633-5526 email technical support toll free
number
zoho phone number 1-888-633-5526 email tech support phone number usa
zoho phone number 1-888-633-5526 email technical support contact number
zoho phone number 1-888-633-5526 email tech support toll free number
zoho phone number 1-888-633-5526 email customer support toll free
number
zoho phone number 1-888-633-5526 email customer service toll free
number
zoho phone number 1-888-633-5526 emailcustomer service phone number
zoho phone number 1-888-633-5526 email customer service number
zoho phone number 1-888-633-5526 email phone customer service
zoho phone number 1-888-633-5526 email customer support
customer service phone number for zoho phone number 1-888-633-5526
email
zoho phone number 1-888-633-5526 email tech support phone number
zoho phone number 1-888-633-5526 email tech support number
zoho phone number 1-888-633-5526 email support phone number
technical support phone number for zoho phone number 1-888-633-5526
email
zoho phone number 1-888-633-5526 email technical support phone number
zoho phone number 1-888-633-5526 email customer support phone number
zoho phone number 1-888-633-5526 emails tech support live
customer service phone number for zoho phone number 1-888-633-5526
email
support tech support phone number for zoho phone number 1-888-633-5526
email
zoho phone number 1-888-633-5526 email tech support telephone number
zoho phone number 1-888-633-5526 emails support phone number
zoho phone number 1-888-633-5526 email support phone number usa
zoho phone number 1-888-633-5526 email customer service phone number
zoho phone number 1-888-633-5526 email phone number for tech support
zoho phone number 1-888-633-5526 emails support center usa
support phone number for zoho phone number 1-888-633-5526 emails
support phone for technical issues
support phone number zoho phone number 1-888-633-5526 email
zoho phone number 1-888-633-5526 email tech support phone number
zoho phone number 1-888-633-5526 email phone number for technician
technician help phone number for zoho phone number 1-888-633-5526 email
technical support phone number usa for zoho phone number 1-888-633-5526
email
technical support phone number
zoho phone number 1-888-633-5526 email tech support live
zoho phone number 1-888-633-5526 email customer service phone number
zoho phone number 1-888-633-5526 emails support center
support phone number for zoho phone number 1-888-633-5526 email
support phone for technical issues for zoho phone number 1-888-633-5526
email
zoho phone number 1-888-633-5526 email customer service toll free
number
zoho phone number 1-888-633-5526 emailcustomer service phone number
zoho phone number 1-888-633-5526 email customer service number
zoho phone number 1-888-633-5526 email phone customer service
zoho phone number 1-888-633-5526 email customer support
customer service phone number for zoho phone number 1-888-633-5526
email
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
phone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
number
zoho phone number 1-888-633-5526 email support phone number
tech 1-888-633-5526 nical support phone number for zoho phone number
1-888-633-5526 email
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 nical
support phone number
zoho phone number 1-888-633-5526 email customer support phone number
zoho phone number 1-888-633-5526 emails tech 1-888-633-5526 support
live
customer service phone number for zoho phone number 1-888-633-5526
email
support tech 1-888-633-5526 support phone number for zoho phone number
1-888-633-5526 email
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
telephone number
zoho phone number 1-888-633-5526 emails support phone number
zoho phone number 1-888-633-5526 email support phone number usa
zoho phone number 1-888-633-5526 email customer service phone number
zoho phone number 1-888-633-5526 email phone number for tech
1-888-633-5526 support
zoho phone number 1-888-633-5526 emails support center usa
support phone number for zoho phone number 1-888-633-5526 emails
support phone for tech 1-888-633-5526 nical issues
support phone number zoho phone number 1-888-633-5526 email
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
phone number
zoho phone number 1-888-633-5526 email phone number for tech
1-888-633-5526 nician
tech 1-888-633-5526 nician help phone number for zoho phone number
1-888-633-5526 email
tech 1-888-633-5526 nical support phone number usa for zoho phone number
1-888-633-5526 email
tech 1-888-633-5526 nical support phone number
zoho phone number 1-888-633-5526 email tech 1-888-633-5526 support
live
zoho phone number 1-888-633-5526 email customer service phone number
zoho phone number 1-888-633-5526 emails support center
support phone number for zoho phone number 1-888-633-5526 email
support phone for tech 1-888-633-5526 nical issues for zoho phone number
1-888-633-5526 email@12++
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:8>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by vinayinvicible):
* Attachment "makemigrations.diff" added.
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by vinayinvicible):
I recently came across this issue and the above patch fixed it.
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:8>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by vinayinvicible):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:9>
Django
makemigrations
Reporter: simonpercivall | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Changes (by vinayinvicible):
* version: 1.9 => 1.10
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:10>
Django
makemigrations
Reporter: Simon Percivall | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Migrations | Version: 1.10
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Changes (by vinay karanam):
* status: new => closed
* resolution: => duplicate
Comment:
duplicate of #27279
--
Ticket URL: <https://code.djangoproject.com/ticket/26693#comment:11>