[Django] #23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed Enter

8 views
Skip to first unread message

Django

unread,
Aug 8, 2014, 2:09:39 PM8/8/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------
Reporter: CollinAnderson | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------
Not sure how long this has been a problem. It just needs
`event.preventDefault()`.

--
Ticket URL: <https://code.djangoproject.com/ticket/23262>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 8, 2014, 2:25:38 PM8/8/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------------------------

Reporter: CollinAnderson | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by CollinAnderson):

* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0


Comment:

actually it's a bit more complicated
https://github.com/django/django/pull/3037

--
Ticket URL: <https://code.djangoproject.com/ticket/23262#comment:1>

Django

unread,
Aug 8, 2014, 2:35:54 PM8/8/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------------------------

Reporter: CollinAnderson | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------

Comment (by charettes):

Could you write a Selenium test for this?

--
Ticket URL: <https://code.djangoproject.com/ticket/23262#comment:2>

Django

unread,
Aug 8, 2014, 4:36:41 PM8/8/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------------------------

Reporter: CollinAnderson | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------

Comment (by collinanderson):

ok Selenium test is there

--
Ticket URL: <https://code.djangoproject.com/ticket/23262#comment:3>

Django

unread,
Aug 8, 2014, 4:38:43 PM8/8/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------------------------
Reporter: CollinAnderson | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by collinanderson):

* type: Uncategorized => Bug


Old description:

> Not sure how long this has been a problem. It just needs
> `event.preventDefault()`.

New description:

Not sure how long this has been a problem.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/23262#comment:4>

Django

unread,
Aug 12, 2014, 4:17:58 PM8/12/14
to django-...@googlegroups.com
#23262: FilteredSelectMultiple SelectFilter2.js don't submit form if user pressed
Enter
--------------------------------+--------------------------------------
Reporter: CollinAnderson | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"85c22dd4c4a406301b4378a4682456dfa1900830"]:
{{{
#!CommitTicketReference repository=""
revision="85c22dd4c4a406301b4378a4682456dfa1900830"
Fixed #23262 -- Made SelectFilter2.js move items on enter Key press.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23262#comment:5>

Reply all
Reply to author
Forward
0 new messages