[Django] #30934: django.db.backends logging output should include the database alias
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
codeinthehole |
Type: New | Status: new
feature |
Component: Database | Version: 2.2
layer (models, ORM) |
Severity: Normal | Keywords: logging
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
As this is essential information when working with database routing.
--
Ticket URL: <https://code.djangoproject.com/ticket/30934>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: logging | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> As this is essential information when working with database routing.
New description:
As this is essential information when working with database routing.
PR: https://github.com/django/django/pull/11994
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:1>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* version: 2.2 => master
* stage: Unreviewed => Accepted
Comment:
[https://github.com/django/django/pull/11994 PR]
This sounds perfectly reasonable to me and is a trivial change.
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:2>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:3>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Ready for checkin => Accepted
Comment:
CarlosMirdeSouza, please check
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist patch-review-checklist] before
you will mark a ticked as "Ready for checkin", few changes are missing
e.g. `versionchanged` admonitions.
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:4>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: logging | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Abhijeet):
Patch: https://github.com/django/django/pull/12265
@felixxm
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:5>
Django
-------------------------------------+-------------------------------------
| Winterbottom
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: logging | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => David Winterbottom
* needs_better_patch: 0 => 1
* status: new => assigned
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:6>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
(models, ORM) |
Severity: Normal | Resolution:
Keywords: logging | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: David Winterbottom => Nick Pope
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
Comment:
New [https://github.com/django/django/pull/14584 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:7>
Django
-------------------------------------+-------------------------------------
Component: Database layer | Version: dev
(models, ORM) |
Keywords: logging | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"fa35c8bdbc6aca65d94d6280fa463d5bc7baa5c0" fa35c8bd]:
{{{
#!CommitTicketReference repository=""
revision="fa35c8bdbc6aca65d94d6280fa463d5bc7baa5c0"
Fixed #30934 -- Included database alias in django.db.backends log
messages.
This is useful when working with database routing as you want to know
where each query is being executed.
Co-authored-by: David Winterbottom <david.win...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30934#comment:8>