[Django] #22490: get_object within a syndication Feed has no tests
Django
-------------------------------------+--------------------
Reporter: danielsamuels | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.syndication | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+--------------------
Within django.tests.syndication_tests.feeds there is a class named
[https://github.com/django/django/blob/master/tests/syndication_tests/feeds.py#L11
ComplexFeed] which extends views.Feed and overrides the get_object()
method, however this class is not used in any tests. There is a reference
to the class in the related urls.py, but again this is unused. This means
that there is currently no test code written for the get_object() method
in django.contrib.syndication.views.Feed and no examples for developers to
follow when writing their own tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/22490>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: danielsamuels | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by danielsamuels):
* needs_better_patch: => 0
* version: 1.6 => master
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:1>
Django
Reporter: danielsamuels | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by danielsamuels):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:2>
Django
Reporter: danielsamuels | Owner: nobody
Type: Bug | Status: new
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted
Comment:
The test may have been inadvertently removed in
c4c27d8a04c9125cfbc5c3611557d8e5d3845b0d.
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:3>
Django
Reporter: danielsamuels | Owner: anonymous
Type: Bug | Status: assigned
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => assigned
* owner: nobody => anonymous
* has_patch: 0 => 1
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
Pull request: https://github.com/django/django/pull/2660
The class was previously used to test complex feed structures implemented
in the function-based syndication - which now is covered by url
dispatching.
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:4>
Django
Reporter: danielsamuels | Owner: anonymous
Component: contrib.syndication | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1ab278f39d9bec7d23adcd459c0028b176d073d4"]:
{{{
#!CommitTicketReference repository=""
revision="1ab278f39d9bec7d23adcd459c0028b176d073d4"
Fixed #22490 -- removed obsolete ComplexFeed class from syndication_tests
It was previously used in a test that was deprecated and then removed,
this cruft can be removed now.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:5>
Django
Reporter: danielsamuels | Owner: anonymous
Type: Bug | Status: closed
Component: contrib.syndication | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by danielsamuels):
With this change, does this mean that functions such as get_object have no
tests at all? This isn't the outcome I was expecting from this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:6>
Django
Reporter: danielsamuels | Owner: anonymous
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* status: closed => new
* has_patch: 1 => 0
* resolution: fixed =>
* stage: Ready for checkin => Accepted
Comment:
Yes, I cannot find a test for this function. The default returns `None`,
but there should probably be one that returns an actual object.
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:7>
Django
Reporter: Daniel Samuels | Owner: anonymous
Type: Bug | Status: new
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:8>
Django
Reporter: Daniel Samuels | Owner: Octavio
Type: Bug | Status: assigned
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------
* owner: anonymous => Octavio
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:9>
Django
Reporter: Daniel Samuels | Owner: Octavio
Cleanup/optimization | Status: closed
Component: contrib.syndication | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"746bb13ceb72d4f5f0e7131cd79a20f669f1d4f6" 746bb13]:
{{{
#!CommitTicketReference repository=""
revision="746bb13ceb72d4f5f0e7131cd79a20f669f1d4f6"
Fixed #22490 -- Added tests for Feed.get_object().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22490#comment:11>