[Django] #29336: No docs for circular inheritance
Django
------------------------------------------------+------------------------
Reporter: Adrian Turjak | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Proper support for circular (recursive) inheritance has been possible
since https://code.djangoproject.com/ticket/22232 was fixed. But we don't
have any docs for this, or at least none that appear to be easy to find.
This is a very useful feature. It allows a lot of power and flexibility
without the need to create many template overrides.
Before Django properly supported this, most of us used:
https://github.com/stephenmcd/django-overextends
The docs from overextends with the basic example as there on that project
are what Django needs. A clear explanation and example of what circular
inheritance is, how it works, and how to use it.
--
Ticket URL: <https://code.djangoproject.com/ticket/29336>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Adrian Turjak):
* owner: nobody => Adrian Turjak
* status: new => assigned
Comment:
Fixed by: https://github.com/django/django/pull/9884
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:1>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
This would make a good addition to the
[https://docs.djangoproject.com/en/2.0/howto/overriding-templates/
Overriding Templates How-To].
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:2>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Component: Documentation | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by Animesh Sinha):
* status: assigned => closed
* resolution: => fixed
Comment:
This issue is resolved, right? The docs were added so should we not mark
this ticket closed?
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:3>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Component: Documentation | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by Simon Charette):
* status: closed => new
* resolution: fixed =>
Comment:
The [https://github.com/django/django/pull/9884 PR has not been merged]
thus this ticket isn't ''fixed''.
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:4>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Component: Documentation | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Comment (by tapaswenipathak):
Hello folks: Can I take the ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:3>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Comment (by felixxm):
I don't think that there is a need to reassign this ticket, discussion is
in progress.
Replying to [comment:3 Tapasweni Pathak]:
> Hello folks: Can I take the ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:4>
Django
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Comment (by Adrian Turjak):
Replying to [comment:3 Tapasweni Pathak]:
> Hello folks: Can I take the ticket?
The current pull request is here:
https://github.com/django/django/pull/9884
If you have opinions on this feature, or how it is documented, that is the
place to voice it :)
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Adrian Turjak | Owner: Adrian
Type: | Turjak
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by frnhr):
* cc: frnhr (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:6>
Django
-------------------------------------+-------------------------------------
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by David Smith):
* owner: Adrian Turjak => David Smith
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/13247 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Adrian Turjak | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by David Smith):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Adrian Turjak | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Adrian Turjak | Owner: David
Type: | Smith
Component: Documentation | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Carlton Gibson <carlton@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2c2f4b37997daf84834547c8abd146cd6e9eac13" 2c2f4b37]:
{{{
#!CommitTicketReference repository=""
revision="2c2f4b37997daf84834547c8abd146cd6e9eac13"
Fixed #29336 -- Doc'd circular template inheritance
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Adrian Turjak | Owner: David
Type: | Smith
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"b81cdaf20d7414b4ff5caba23477d8bdb0cb08e8" b81cdaf2]:
{{{
#!CommitTicketReference repository=""
revision="b81cdaf20d7414b4ff5caba23477d8bdb0cb08e8"
[3.1.x] Fixed #29336 -- Doc'd circular template inheritance
Backport of 2c2f4b37997daf84834547c8abd146cd6e9eac13 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29336#comment:11>