[Django] #29307: Incorrect introspection of django.contrib.postgres fields.

3 views
Skip to first unread message

Django

unread,
Apr 9, 2018, 12:20:48 PM4/9/18
to django-...@googlegroups.com
#29307: Incorrect introspection of django.contrib.postgres fields.
------------------------------------------+------------------------
Reporter: Alasdair Nicol | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
The introspection rules for django.contrib.postgres fields incorrectly use
`django.contrib.postgresql`.

https://github.com/django/django/blob/a599ae6018f748f66e774604d12989911ea09d33/django/contrib/postgres/apps.py#L20

As reported on [https://stackoverflow.com/questions/49736688/inspectdb-
command-for-json-in-django2-generates-django-contrib-postgresql-
fields/49737317#49737317 Stack Overflow]

--
Ticket URL: <https://code.djangoproject.com/ticket/29307>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 9, 2018, 12:20:58 PM4/9/18
to django-...@googlegroups.com
#29307: Incorrect introspection of django.contrib.postgres fields.
--------------------------------+------------------------------------------
Reporter: Alasdair Nicol | Owner: Alasdair Nicol
Type: Bug | Status: assigned
Component: Migrations | Version: 2.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Alasdair Nicol):

* status: new => assigned
* owner: nobody => Alasdair Nicol


--
Ticket URL: <https://code.djangoproject.com/ticket/29307#comment:1>

Django

unread,
Apr 9, 2018, 12:47:53 PM4/9/18
to django-...@googlegroups.com
#29307: inspectdb generates Incorrect import paths for contrib.postgres fields
-------------------------------------+-------------------------------------

Reporter: Alasdair Nicol | Owner: Alasdair
| Nicol
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 2.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* component: Migrations => contrib.postgres
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29307#comment:2>

Django

unread,
Apr 9, 2018, 12:54:13 PM4/9/18
to django-...@googlegroups.com
#29307: inspectdb generates Incorrect import paths for contrib.postgres fields
-------------------------------------+-------------------------------------
Reporter: Alasdair Nicol | Owner: Alasdair
| Nicol
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 2.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Alasdair Nicol):

* has_patch: 0 => 1


Comment:

Pull request: https://github.com/django/django/pull/9865

--
Ticket URL: <https://code.djangoproject.com/ticket/29307#comment:3>

Django

unread,
Apr 10, 2018, 9:58:57 AM4/10/18
to django-...@googlegroups.com
#29307: inspectdb generates Incorrect import paths for contrib.postgres fields
-------------------------------------+-------------------------------------
Reporter: Alasdair Nicol | Owner: Alasdair
| Nicol
Type: Bug | Status: closed
Component: contrib.postgres | Version: 2.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"65c44a5c1d5412d402af19480e3c1c3e3e88893a" 65c44a5c]:
{{{
#!CommitTicketReference repository=""
revision="65c44a5c1d5412d402af19480e3c1c3e3e88893a"
Fixed #29307 -- Fixed inspectdb import paths for django.contrib.postgres
fields.

Thanks erindy for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29307#comment:4>

Django

unread,
Apr 10, 2018, 10:01:32 AM4/10/18
to django-...@googlegroups.com
#29307: inspectdb generates Incorrect import paths for contrib.postgres fields
-------------------------------------+-------------------------------------
Reporter: Alasdair Nicol | Owner: Alasdair
| Nicol
Type: Bug | Status: closed
Component: contrib.postgres | Version: 2.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0eb71b85bf7705f7418fae2572fe1960dd514300" 0eb71b85]:
{{{
#!CommitTicketReference repository=""
revision="0eb71b85bf7705f7418fae2572fe1960dd514300"
[2.0.x] Fixed #29307 -- Fixed inspectdb import paths for
django.contrib.postgres fields.

Thanks erindy for the report.

Backport of 65c44a5c1d5412d402af19480e3c1c3e3e88893a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29307#comment:5>

Reply all
Reply to author
Forward
0 new messages