[Django] #21793: Require specific versions of test suite's Python dependencies?
Django
-------------------------------------+-------------------------------------
Reporter: JustinTArthur | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Testing framework | Keywords: testing,test
Severity: Normal | suite,continuous
Triage Stage: Unreviewed | integration,ci,dependencies,pip,pypi
Easy pickings: 0 | Has patch: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Currently, there are several tests that depend on 3rd party libraries that
we haven't assimilated into the source code directly. These tests are
simply skipped/passed when a developer or tester's environment is missing
one of these libraries.
The question is:
Do we want to specify the preferred versions of these dependencies in
[https://github.com/django/django/tree/master/tests/requirements
test/requirements/*.txt]?
Additionally:
Do we want to have the CI environment(s) use those text files for the
automated testing we do? (they currently don't according to
[https://github.com/timgraham timo])
I vote for at least adjusting those text files to refer to the same
dependency versions as our CI environments are currently using for the
sake of giving contributors a consistent regression testing process (their
passing-on-local test less likely to fail-on-continuous-integration).
We may also have a day when a developer's local test suite goes red, not
because Django has regressed, but because one of the test's dependencies
has changed in API or behavior. This could be desired behavior? I don't
know.
Ticket inspired by a #django-dev conversation with
[https://github.com/timgraham timo] on 2014-01-16 with regards to
[https://github.com/django/django/pull/2173 pull request 2173], which adds
a dependency to a specific version of a 3rd-party library.
--
Ticket URL: <https://code.djangoproject.com/ticket/21793>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: JustinTArthur | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Severity: Normal | Triage Stage:
Keywords: testing,test | Unreviewed
suite,continuous | Needs documentation: 0
integration,ci,dependencies,pip,pypi| Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by JustinTArthur):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Where these dependencies are currently documented (outside those
`pip`-readable textfiles):
https://docs.djangoproject.com/en/1.6/internals/contributing/writing-code
/unit-tests/#running-all-the-tests
--
Ticket URL: <https://code.djangoproject.com/ticket/21793#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: JustinTArthur | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Severity: Normal | Triage Stage: Accepted
Keywords: testing,test | Needs documentation: 0
suite,continuous | Patch needs improvement: 0
integration,ci,dependencies,pip,pypi| UI/UX: 0
Has patch: 0 |
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
I think this is likely to happen at some point.
--
Ticket URL: <https://code.djangoproject.com/ticket/21793#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: JustinTArthur | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Severity: Normal | Resolution: wontfix
Keywords: testing,test | Triage Stage: Accepted
suite,continuous |
integration,ci,dependencies,pip,pypi|
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* status: new => closed
* resolution: => wontfix
Comment:
18 months later, the status quo seems okay to me. When there are new
versions of dependencies that don't work with older versions of Django, we
add specific version requirements at that time.
--
Ticket URL: <https://code.djangoproject.com/ticket/21793#comment:3>