[Django] #21594: Add note to docs about model formsets deleting objects on save with commit=False
Django
commit=False
-------------------------------+--------------------
Reporter: benspaulding | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
Some users may interpret `commit=False` to mean that no changes are
commited to the database, when deletions actually are (as far as I
understand).
Patch at [https://github.com/django/django/pull/2062 Pull Request #2062]
--
Ticket URL: <https://code.djangoproject.com/ticket/21594>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by charettes):
* needs_better_patch: => 0
* needs_docs: => 0
* version: master => 1.6
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
As pointed out on the PR it seems like this should be fixed in the future
1.7.x release (see #10284).
Accepting because it might cause unexpected data losses and be worth the
backport effort to the documentation of previous releases.
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:1>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by benspaulding):
Replying to [comment:1 charettes]:
> As pointed out on the PR it seems like this should be fixed in the
future 1.7.x release (see #10284).
Thanks for pointing that out. I searched for related tickets, but I guess
I only searched open tickets, so I did not see #10284.
> Accepting because it might cause unexpected data losses and be worth the
backport effort to the documentation of previous releases.
That sounds good. Do you need me to modify the pull request, or create a
new one that puts that note in stable/1.6.x, or just attach a patch in
Trac? Let me know how I can help.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:2>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by charettes):
Please open a new PR against stable/1.6.x with the additional note that it
has been fixed in Django 1.7.
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:3>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by charettes):
* needs_better_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:4>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by benspaulding):
New pull request against stable/1.6.x,
[https://github.com/django/django/pull/2063 #2063].
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:5>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Simon Charette <charette.s@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"de1d5d5df5238136e8cd114e36065857bee1ace4"]:
{{{
#!CommitTicketReference repository=""
revision="de1d5d5df5238136e8cd114e36065857bee1ace4"
[1.6.x] Fixed #21594 -- Added note about model formsets deleting objects.
This behavior has been fixed in 65e03a424e. refs #10284.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:6>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Simon Charette <charette.s@…>):
In [changeset:"a53820b1b1747d6f9b5ee5723aa7526ededdaba7"]:
{{{
#!CommitTicketReference repository=""
revision="a53820b1b1747d6f9b5ee5723aa7526ededdaba7"
[1.5.x] Fixed #21594 -- Added note about model formsets deleting objects.
This behavior has been fixed in 65e03a424e. refs #10284.
Backport of de1d5d5df5 from stable/1.6.x.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:7>
Django
commit=False
Reporter: benspaulding | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Simon Charette <charette.s@…>):
In [changeset:"474e7dd6d08105fce66d7f62670a6c120c0b1198"]:
{{{
#!CommitTicketReference repository=""
revision="474e7dd6d08105fce66d7f62670a6c120c0b1198"
[1.4.x] Fixed #21594 -- Added note about model formsets deleting objects.
This behavior has been fixed in 65e03a424e. refs #10284.
Backport of de1d5d5df5 from stable/1.6.x.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21594#comment:8>