[Django] #24972: Removing unique_together constraint makes migration fail on Django 1.8.2 with MySQL
Django
with MySQL
------------------------------+--------------------
Reporter: adambrenecki | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
Migrations containing `migrations.AlterUniqueTogether(name='xxx',
unique_together=set([]),)` may fail on Django 1.8 but not on Django 1.7 if
using the backend mysql, but in a slightly different way than in #24757.
Given the following models:
{{{#!python
from django.db import models
# Create your models here.
class FkTarget(models.Model):
pass
class TheModel(models.Model):
fk = models.ForeignKey(FkTarget)
other = models.IntegerField()
}}}
And the following migrations:
{{{#!python
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from django.db import models, migrations
class Migration(migrations.Migration):
dependencies = [
]
operations = [
migrations.CreateModel(
name='FkTarget',
fields=[
('id', models.AutoField(verbose_name='ID',
serialize=False, auto_created=True, primary_key=True)),
],
),
migrations.CreateModel(
name='TheModel',
fields=[
('id', models.AutoField(verbose_name='ID',
serialize=False, auto_created=True, primary_key=True)),
('other', models.IntegerField()),
],
),
migrations.AddField(
model_name='themodel',
name='fk',
field=models.ForeignKey(default=1, to='ta.FkTarget'),
preserve_default=False,
),
migrations.AlterUniqueTogether(
name='themodel',
unique_together=set([('fk', 'other')]),
),
]
}}}
{{{#!python
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from django.db import models, migrations
class Migration(migrations.Migration):
dependencies = [
('ta', '0001_initial'),
]
operations = [
migrations.AlterUniqueTogether(
name='themodel',
unique_together=set([]),
),
]
}}}
I get the following error when migrating:
{{{
Applying ta.0001_initial... OK
Applying ta.0002_auto_20150612_0354...Traceback (most recent call last):
[snip traceback]
django.db.utils.OperationalError: (1061, "Duplicate key name
'ta_themodel_4195ef88'")
}}}
What seems to be happening here is that the `AddField` is doing a `CREATE
INDEX` on the `fk` field, then the final `AlterUniqueTogether` is trying
to recreate the already-existing index.
(Interestingly, if the foreign key is introduced as part of the
`CreateModel` rather than as an `AddField` - which is how it was in #24757
- I don't see the first `CREATE INDEX` in `sqlmigrate`, and the whole
thing works without errors.)
I think I've managed to figure out what's causing it and fix the issue;
I'll post my patch up to GitHub shortly.
In case it's relevant:
{{{
$ mysqld --version
150612 13:42:17 [Warning] Using unique option prefix key_buffer instead of
key_buffer_size is deprecated and will be removed in a future release.
Please use the full name instead.
mysqld Ver 5.5.43-0ubuntu0.14.04.1-log for debian-linux-gnu on x86_64
((Ubuntu))
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24972>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
with MySQL
Reporter: adambrenecki | Owner: adambrenecki
Type: Bug | Status: assigned
Component: Migrations | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by adambrenecki):
* owner: nobody => adambrenecki
* needs_docs: => 0
* status: new => assigned
* needs_tests: => 0
* needs_better_patch: => 0
Comment:
So I have a patch for this, I just haven't written a regression test yet.
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:1>
Django
with MySQL
Reporter: adambrenecki | Owner: adambrenecki
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by shaib):
#24934 seems to describe the same problem and was marked as fixed. Can you
please check against master?
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:2>
Django
with MySQL
Reporter: adambrenecki | Owner: adambrenecki
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by adambrenecki):
Replying to [comment:2 shaib]:
> #24934 seems to describe the same problem and was marked as fixed. Can
you please check against master?
>
Same problem on master for me.
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:3>
Django
with MySQL
Reporter: adambrenecki | Owner: adambrenecki
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:4>
Django
with MySQL
Reporter: adambrenecki | Owner: adambrenecki
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by adambrenecki):
* has_patch: 0 => 1
Comment:
OK, patch is here: https://github.com/django/django/pull/4859
Sorry it took so long; I had issues with djangocore-box on Friday and
didn't have time over the weekend :(
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:5>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
Comment:
Made some minor edits and now running tests locally just to double check.
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:6>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Component: Migrations | Version: 1.8
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"65296b3be376e9cd25216b6ad2b1758b03765781" 65296b3]:
{{{
#!CommitTicketReference repository=""
revision="65296b3be376e9cd25216b6ad2b1758b03765781"
Fixed #24972 -- Fixed removing unique_together indexes on MySQL.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:7>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"0e3a80fa683bcc8c6ea4036ad81b6b882234e795" 0e3a80f]:
{{{
#!CommitTicketReference repository=""
revision="0e3a80fa683bcc8c6ea4036ad81b6b882234e795"
[1.8.x] Fixed #24972 -- Fixed removing unique_together indexes on MySQL.
Backport of 65296b3be376e9cd25216b6ad2b1758b03765781 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:8>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by adamn):
* version: 1.8 => 1.9
Comment:
This still seems to be a problem.
MySQL 5.6
Django 1.9.4
Python 3.5
In this case I'm dropping a unique_with constraint on a table called
"stream_streamaccess"
{{{
class Migration(migrations.Migration):
dependencies = [
('stream', '0002_auto_20160406_1501'),
]
operations = [
migrations.AlterUniqueTogether(
name='streamaccess',
unique_together=set([]),
),
]
}}}
{{{
Running migrations:
Rendering model states... DONE
Applying stream.0003_auto_20160406_2130...Traceback (most recent call
last):
File "/var/www/centr/manage.py", line 13, in <module>
execute_from_command_line(sys.argv)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/core/management/__init__.py", line 353, in
execute_from_command_line
utility.execute()
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/core/management/__init__.py", line 345, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/core/management/base.py", line 348, in run_from_argv
self.execute(*args, **cmd_options)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/core/management/base.py", line 399, in execute
output = self.handle(*args, **options)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/core/management/commands/migrate.py", line 200, in handle
executor.migrate(targets, plan, fake=fake, fake_initial=fake_initial)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/migrations/executor.py", line 92, in migrate
self._migrate_all_forwards(plan, full_plan, fake=fake,
fake_initial=fake_initial)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/migrations/executor.py", line 121, in
_migrate_all_forwards
state = self.apply_migration(state, migration, fake=fake,
fake_initial=fake_initial)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/migrations/executor.py", line 198, in apply_migration
state = migration.apply(state, schema_editor)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/migrations/migration.py", line 123, in apply
operation.database_forwards(self.app_label, schema_editor, old_state,
project_state)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/migrations/operations/models.py", line 359, in
database_forwards
getattr(new_model._meta, self.option_name, set()),
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/backends/base/schema.py", line 318, in
alter_unique_together
self._delete_composed_index(model, fields, {'unique': True},
self.sql_delete_unique)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/backends/mysql/schema.py", line 87, in
_delete_composed_index
return super(DatabaseSchemaEditor, self)._delete_composed_index(model,
fields, *args)
File "/var/virtualenvs/centr/lib/python3.5/site-
packages/django/db/backends/base/schema.py", line 347, in
_delete_composed_index
", ".join(columns),
ValueError: Found wrong number (0) of constraints for
stream_streamaccess(stream_id, user_id, role)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:9>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Type: Bug | Status: closed
Component: Migrations | Version: 1.9
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
Please open a new ticket with steps to reproduce (such as a sample
project).
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:10>
Django
with MySQL
Reporter: adambrenecki | Owner:
| adambrenecki
Type: Bug | Status: closed
Component: Migrations | Version: 1.9
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by adamn):
I just tried replicating and couldn't get it to happen again.
Unfortunately I fried all of my previous migrations to get it to work on
the real project and my test project starting from scratch worked fine. I
guess we'll leave well enough alone.
--
Ticket URL: <https://code.djangoproject.com/ticket/24972#comment:11>