[Django] #25115: admindocs view bookmarklet assumes url of admindocs

7 views
Skip to first unread message

Django

unread,
Jul 12, 2015, 4:14:01 PM7/12/15
to django-...@googlegroups.com
#25115: admindocs view bookmarklet assumes url of admindocs
-----------------------------------+--------------------------
Reporter: benspaulding | Owner: benspaulding
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-----------------------------------+--------------------------
The admindocs have four bookmarklets, one of which links to the admindocs
view detail page. )You save the bookmarklet, then click on it while
looking at a view on your site. It then takes you to the admindocs for
that view.) It assumes that the admindocs are wired up at /admin/docs/. It
should instead reverse the appropriate URL so that the bookmarklet works
no matter what URL the admindocs are served from.

--
Ticket URL: <https://code.djangoproject.com/ticket/25115>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 13, 2015, 8:53:22 AM7/13/15
to django-...@googlegroups.com
#25115: admindocs view bookmarklet assumes url of admindocs
-------------------------------------+-------------------------------------

Reporter: benspaulding | Owner:
| benspaulding
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25115#comment:1>

Django

unread,
Jul 13, 2015, 12:48:18 PM7/13/15
to django-...@googlegroups.com
#25115: admindocs view bookmarklet assumes url of admindocs
-------------------------------------+-------------------------------------
Reporter: benspaulding | Owner:
| benspaulding
Type: Bug | Status: closed
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"915ef79b08862680e82d6a772d6ead22735e9a2f" 915ef79]:
{{{
#!CommitTicketReference repository=""
revision="915ef79b08862680e82d6a772d6ead22735e9a2f"
Fixed #25115 -- Made admindocs view bookmarklet reverse the URL rather
than hardcode it.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25115#comment:2>

Reply all
Reply to author
Forward
0 new messages