[Django] #27158: Small issue with positioning admin page filters in RTL languages

5 views
Skip to first unread message

Django

unread,
Aug 31, 2016, 5:50:00 AM8/31/16
to django-...@googlegroups.com
#27158: Small issue with positioning admin page filters in RTL languages
-------------------------------+----------------------------
Reporter: mehdipourfar | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Keywords: admin, ui, css
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+----------------------------
Admin's filters were floated to left in RTL version and not vertically
aligned.

I've fixed it and sent a pull request here.
https://github.com/django/django/pull/7183

Before:
[[Image(http://sl.uploads.im/t/0B6JX.jpg)]]
After:
[[Image(http://sk.uploads.im/t/J8AqP.jpg)]]

--
Ticket URL: <https://code.djangoproject.com/ticket/27158>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 31, 2016, 5:54:13 AM8/31/16
to django-...@googlegroups.com
#27158: Small issue with positioning admin page filters in RTL languages
--------------------------------+--------------------------------------

Reporter: mehdipourfar | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:

Keywords: admin, ui, css | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------
Changes (by bmispelon):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Hi,

The screenshots are really small and make it hard to see what's changed
exactly.

Could you re-upload them directly to the ticket (use the "Attachments"
feature of Trac)?
Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/27158#comment:1>

Django

unread,
Aug 31, 2016, 7:23:38 AM8/31/16
to django-...@googlegroups.com
#27158: Small issue with positioning admin page filters in RTL languages
--------------------------------+--------------------------------------

Reporter: mehdipourfar | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:

Keywords: admin, ui, css | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------

Comment (by mehdipourfar):

Hi,
Larger images are here:

http://uploads.im/0B6JX.jpg
http://uploads.im/J8AqP.jpg

I've blurrified images but the only important thing is the position of
filter horizontal boxes that one can see even in thumbnails.
Thank you for your consideration.

--
Ticket URL: <https://code.djangoproject.com/ticket/27158#comment:2>

Django

unread,
Aug 31, 2016, 10:04:28 AM8/31/16
to django-...@googlegroups.com
#27158: Incorrect positioning of admin' horizontal/vertical filter widgets in RTL
languages
--------------------------------+------------------------------------

Reporter: mehdipourfar | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: admin, ui, css | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted
* easy: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27158#comment:3>

Django

unread,
Sep 8, 2016, 7:46:24 PM9/8/16
to django-...@googlegroups.com
#27158: Incorrect positioning of admin' horizontal/vertical filter widgets in RTL
languages
--------------------------------+------------------------------------
Reporter: mehdipourfar | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: admin, ui, css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
--------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27158#comment:4>

Django

unread,
Sep 22, 2016, 7:24:16 PM9/22/16
to django-...@googlegroups.com
#27158: Incorrect positioning of admin' horizontal/vertical filter widgets in RTL
languages
--------------------------------+------------------------------------
Reporter: Mehdi Pourfar | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: admin, ui, css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"13a8e633c273530ebd8d93490a7341a8aabb7346" 13a8e63]:
{{{
#!CommitTicketReference repository=""
revision="13a8e633c273530ebd8d93490a7341a8aabb7346"
Fixed #27158 -- Fixed positioning of admin's many-to-many widgets in
rtl.css.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27158#comment:5>

Reply all
Reply to author
Forward
0 new messages