[Django] #24599: BaseInlineFormSet.add_fields(self, form, index) add field to form._meta multiple times

33 views
Skip to first unread message

Django

unread,
Apr 8, 2015, 3:16:42 AM4/8/15
to django-...@googlegroups.com
#24599: BaseInlineFormSet.add_fields(self, form, index) add field to form._meta
multiple times
------------------------------+--------------------
Reporter: malyshevalex | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
In method BaseInlineFormSet.add_fields(self, form, index):
{{{
if form._meta.fields:
if isinstance(form._meta.fields, tuple):
form._meta.fields = list(form._meta.fields)
form._meta.fields.append(self.fk.name)
}}}
Forms in InlineFormSet has same _meta attribute. And foreign key field add
to _meta multiple times.

--
Ticket URL: <https://code.djangoproject.com/ticket/24599>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 8, 2015, 7:19:28 AM4/8/15
to django-...@googlegroups.com
#24599: BaseInlineFormSet.add_fields(self, form, index) add field to form._meta
multiple times
------------------------------+--------------------------------------
Reporter: malyshevalex | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 1.8
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Changes (by timgraham):

* status: new => closed
* needs_better_patch: => 0
* resolution: => duplicate
* needs_tests: => 0
* needs_docs: => 0


Comment:

The description is a bit light, but this seems like a duplicate of #21332.

--
Ticket URL: <https://code.djangoproject.com/ticket/24599#comment:1>

Reply all
Reply to author
Forward
0 new messages