[Django] #22336: Impossible to exclude specific subdirectories with makemessages
Django
--------------------------------------------+--------------------
Reporter: infraredgirl | Owner: nobody
Type: Bug | Status: new
Component: Core (Management commands) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------------+--------------------
As described in https://code.djangoproject.com/ticket/20422#comment:4, it
is currently impossible to exclude subdirectories, or files in
subdirectories, using the --ignore option of makemessages management
command. This used to work in Django 1.5, but a regression was introduced
by the fix for above mention ticket #20422.
The new patch should make sure to include unit tests which test for
correct behavior of the --ignore option of makemessages, specifically in
the case of subdirectories.
E.g:
makemessages --ignore dir/subdir/*
makemessages --ignore dir/*/file.py
etc.
--
Ticket URL: <https://code.djangoproject.com/ticket/22336>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: infraredgirl | Owner:
Type: Bug | anubhav9042
Component: Core (Management | Status: assigned
commands) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by anubhav9042):
* status: new => assigned
* needs_better_patch: => 0
* owner: nobody => anubhav9042
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:1>
Django
Reporter: infraredgirl | Owner:
Type: Bug | Status: new
Component: Core (Management | Version: master
commands) | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by anubhav9042):
* owner: anubhav9042 =>
* status: assigned => new
Comment:
There is some problem in running of makemessages in my django
installation. So I am deassigning myself.
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:2>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by justhamade):
* status: new => assigned
* owner: => justhamade
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:3>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by justhamade):
Created pull request https://github.com/django/django/pull/2572
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:4>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by justhamade):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:5>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
commands) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8fe406864c5bbdd20e32d6127d377ed292006c5c"]:
{{{
#!CommitTicketReference repository=""
revision="8fe406864c5bbdd20e32d6127d377ed292006c5c"
Fixed #22336 -- Added path matching for makemessages ignore option
This fixes a regression introduced by 9012a9e200.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:6>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"98d6f128d0fd5aec0c8d49da273e369e8345a726"]:
{{{
#!CommitTicketReference repository=""
revision="98d6f128d0fd5aec0c8d49da273e369e8345a726"
[1.7.x] Fixed #22336 -- Added path matching for makemessages ignore option
This fixes a regression introduced by 9012a9e200.
Backport of 8fe406864c from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:7>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Ramiro Morales <ramiro@…>):
In [changeset:"b4dce7c37ab7666b023ac791d2c46dad6c8aa637"]:
{{{
#!CommitTicketReference repository=""
revision="b4dce7c37ab7666b023ac791d2c46dad6c8aa637"
Fixed #23298 -- Made makemessages actually ignore specified dirs on
Windows.
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422, refs #22336
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:8>
Django
Reporter: infraredgirl | Owner:
Type: Bug | justhamade
Component: Core (Management | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"126606c5b8499830cd56cbe632f6af17bc7471ea"]:
{{{
#!CommitTicketReference repository=""
revision="126606c5b8499830cd56cbe632f6af17bc7471ea"
[1.7.x] Fixed #23298 -- Made makemessages actually ignore specified dirs
on Windows.
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422, refs #22336
Backport of b4dce7c37a from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22336#comment:9>