[Django] #30339: Model.delete(keep_parents=True) does not preserve all parent reverse relationships

71 views
Skip to first unread message

Django

unread,
Apr 8, 2019, 6:46:45 AM4/8/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
december1981 |
Type: | Status: new
Uncategorized |
Component: Database | Version: 2.2
layer (models, ORM) |
Severity: Normal | Keywords: models deletion
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
There was a partial fix for this in #27407, but it doesn't cater for
relationships toward parent's of parents, and so on.

--
Ticket URL: <https://code.djangoproject.com/ticket/30339>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 8, 2019, 6:47:03 AM4/8/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: december1981 | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution:

Keywords: models deletion | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by december1981):

* type: Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:1>

Django

unread,
Apr 8, 2019, 6:49:15 AM4/8/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: december1981 | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master

(models, ORM) |
Severity: Normal | Resolution:
Keywords: models deletion | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by december1981):

* version: 2.2 => master


Comment:

Pull request
https://github.com/django/django/pull/11185

--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:2>

Django

unread,
Apr 8, 2019, 6:51:00 AM4/8/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: december1981 | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models deletion | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by december1981:

Old description:

> There was a partial fix for this in #27407, but it doesn't cater for
> relationships toward parent's of parents, and so on.

New description:

There was a partial fix for this in #27407, but it doesn't cater for

relationships toward parents of parents, and so on.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:3>

Django

unread,
Apr 14, 2019, 4:57:53 AM4/14/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: Stephen Brown | Owner: nobody

Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models deletion | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tobias Kunze):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:4>

Django

unread,
Apr 14, 2019, 8:49:50 AM4/14/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: Stephen Brown | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models deletion | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Stephen Brown):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:5>

Django

unread,
Apr 15, 2019, 4:41:21 PM4/15/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: Stephen Brown | Owner: Stephen
| Brown
Type: Bug | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models deletion | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tobias Kunze):

* status: new => assigned
* owner: nobody => Stephen Brown


--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:6>

Django

unread,
May 6, 2019, 8:01:53 AM5/6/19
to django-...@googlegroups.com
#30339: Model.delete(keep_parents=True) does not preserve all parent reverse
relationships
-------------------------------------+-------------------------------------
Reporter: Stephen Brown | Owner: Stephen
| Brown
Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: models deletion | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"86a3ad351ec18d9dcd50cac1fc8ada6f904675db" 86a3ad35]:
{{{
#!CommitTicketReference repository=""
revision="86a3ad351ec18d9dcd50cac1fc8ada6f904675db"
Fixed #30339 -- Made Model.delete(keep_parents=True) preserves nested
parent reverse relationships.

Thanks Simon Charette for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30339#comment:7>

Reply all
Reply to author
Forward
0 new messages