[Django] #27085: UI Discrepancy in "Writing your first Django app, part 2"
Django
--------------------------------------+--------------------
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Hi
Here's reporting UI Discrepancy in "Writing your first Django app, part 2"
tutorial.
As per https://docs.djangoproject.com/en/1.10/intro/tutorial02/, "Home ›
Polls › Questions" is shown displaying Check Box: "QUESTION TEXT".
However, the actual out from the code displays Check Box: "QUESTION". The
code was run on the following environments:
CentOS 7.1 64-Bit
Django 1.9.6
Python 2.7.5
pip 8.1.1
Windows 8.1 64-Bit
Django 1.10
Python 2.7.11
pip 8.1.2
Windows 7 64-Bit
Django 1.8.2
Python 3.4.3
Thanks
--
Ticket URL: <https://code.djangoproject.com/ticket/27085>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
Changes (by pluralschool):
* Attachment "Tutorial.JPG" added.
Django
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
Changes (by pluralschool):
* Attachment "Actual.JPG" added.
Django
Reporter: pluralschool | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by pluralschool):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> Hi
>
> Here's reporting UI Discrepancy in "Writing your first Django app, part
> 2" tutorial.
>
> As per https://docs.djangoproject.com/en/1.10/intro/tutorial02/, "Home ›
> Polls › Questions" is shown displaying Check Box: "QUESTION TEXT".
> However, the actual out from the code displays Check Box: "QUESTION". The
> code was run on the following environments:
>
> CentOS 7.1 64-Bit
> Django 1.9.6
> Python 2.7.5
> pip 8.1.1
>
> Windows 8.1 64-Bit
> Django 1.10
> Python 2.7.11
> pip 8.1.2
>
> Windows 7 64-Bit
> Django 1.8.2
> Python 3.4.3
>
> Thanks
New description:
Hi
Here's reporting UI Discrepancy in "Writing your first Django app, part 2"
tutorial. Please refer to the screenshots (Tutorial.JPG and Actual.JPG).
As per https://docs.djangoproject.com/en/1.10/intro/tutorial02/, "Home ›
Polls › Questions" is shown displaying Check Box: "QUESTION TEXT"(vide
Tutorial.JPG). However, the actual out from the code displays Check Box:
"QUESTION" (vide Actual.JPG). The code was run on the following
environments:
CentOS 7.1 64-Bit
Django 1.9.6
Python 2.7.5
Windows 8.1 64-Bit
Django 1.10
Python 2.7.11
Windows 7 64-Bit
Django 1.8.2
Python 3.4.3
Thanks
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:1>
Django
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bmispelon):
* stage: Unreviewed => Accepted
Comment:
Hi,
Indeed, the screenshot in the tutorial is incorrect.
Thanks for spotting that.
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:2>
Django
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by bmispelon):
* easy: 0 => 1
Comment:
Regenerating the image will be tricky because we want to match the style
of the others.
However, in this instance we should be able to use an image-editing
software to crop out the word "TEXT" and replace it with a solid gray
backround.
The image to edit is located in `docs/intro/_images/admin04t.png`.
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:3>
Django
Reporter: pluralschool | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by timgraham):
See also [https://docs.djangoproject.com/en/dev/internals/contributing
/writing-documentation/#minimizing-images Minimizing images] for post
processing to do on the image.
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:4>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by berabhishek):
* owner: nobody => berabhishek
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:5>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by berabhishek):
New image added.
Bug fixed on branch berabhishek:ticket_27085
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:6>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:7>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* resolution: fixed =>
Comment:
Please don't set the resolution to fixed before the patch is committed to
Django master.
Also could you please make a pull request, then set the `Has patch` flag?
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:8>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by bmispelon):
As Claude said, please create a pull request from your branch, it will
make it easier for us to leave comments on it (there should be a big green
button on
https://github.com/django/django/compare/master...berabhishek:ticket_27085).
Regarding the image, I see two issues:
1) The size is different from the original. Please crop/resize it so that
your image is the same size as the old one (930x279).
2) The "Action" select menu looks different from the old one and is now
inconsistent with the other screenshots. This is the problem I described
in my comment earlier.
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:9>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by berabhishek):
Replying to [comment:8 claudep]:
> Please don't set the resolution to fixed before the patch is committed
to Django master.
>
> Also could you please make a pull request, then set the `Has patch`
flag?
Thank you very much... point taken...
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:10>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:11>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by berabhishek):
Replying to [comment:9 bmispelon]:
> As Claude said, please create a pull request from your branch, it will
make it easier for us to leave comments on it (there should be a big green
button on
https://github.com/django/django/compare/master...berabhishek:ticket_27085).
>
> Regarding the image, I see two issues:
>
> 1) The size is different from the original. Please crop/resize it so
that your image is the same size as the old one (930x279).
> 2) The "Action" select menu looks different from the old one and is now
inconsistent with the other screenshots. This is the problem I described
in my comment earlier.
>
>
> Thanks.
Thank You very much for pointing them out...
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:12>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:13>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by berabhishek):
The bug is fixed in the branch berabhishek:ticket_27085
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:14>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
Hi,
Thanks for opening the pull request and fixing the size issue.
However, you haven't addressed my issue number 2: the form elements in
your new screenshot are now inconsistent with the other screenshots on the
page (checbox, select).
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:15>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f878b860d1bf91c0b5acab133d9636680253884b" f878b86]:
{{{
#!CommitTicketReference repository=""
revision="f878b860d1bf91c0b5acab133d9636680253884b"
[1.10.x] Fixed #27085 -- Corrected a screenshot in the tutorial.
Backport of 44c306218ff5f1b1748040ee3ffd767c4bc33533 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:16>
Django
Reporter: pluralschool | Owner:
Type: | berabhishek
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"44c306218ff5f1b1748040ee3ffd767c4bc33533" 44c30621]:
{{{
#!CommitTicketReference repository=""
revision="44c306218ff5f1b1748040ee3ffd767c4bc33533"
Fixed #27085 -- Corrected a screenshot in the tutorial.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27085#comment:17>