[Django] #28236: Integrate dj-database-url into Django Core
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
kennethreitz |
Type: | Status: new
Uncategorized |
Component: Core | Version: 1.11
(Other) | Keywords: settings, dj-
Severity: Normal | database-url, database_url
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
dj-database-url gives Django developers two main things:
1. the ability to represent their database settings via a string (a-la
sqlalchemy); very useful for environmnent variables and 12factor apps.
2. it will automatically use the DATABASE_URL environment variable, if
present.
I'm not sure if #2 is appropriate for Django Core (but it would be nice,
as Gunicorn supports both PORT and WEB_CONCURRENCY), but I know #1 is
perfect. This plan has previously been discussed (at a conference,
DjangoCon EU in Zurich, long ago) and approved by JKM, before his role at
Heroku, if that is helpful information.
I think this change would vastly improve the usability of Django, and
would be an excellent and simple move for the project.
Many thanks for your consideration. <3
--
Kenneth Reitz
P.S. There is no "Settings" component in the issue tracker, that I can
find.
--
Ticket URL: <https://code.djangoproject.com/ticket/28236>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Kenneth Reitz | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* type: Uncategorized => New feature
* stage: Unreviewed => Someday/Maybe
Comment:
It's better to propose something like this on the DevelopersMailingList
where it'll receive more feedback.
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:1>
Django
Reporter: Kenneth Reitz | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Kenneth Reitz):
Thanks! I'll like to this ticket there.
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:2>
Django
Reporter: Kenneth Reitz | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
[https://groups.google.com/d/topic/django-
developers/G0TtlhH2RUE/discussion django-developers discussion]
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:3>
Django
Reporter: Kenneth Reitz | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Tom):
I've made an initial PR: https://github.com/django/django/pull/8562
I copied most of the 'guts' of the library and fixed up all the tests.
I don't think this is anywhere near ready to merge, but I like the idea
and I thought I would take the first step and propose one way to integrate
the library.
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:4>
Django
Reporter: Kenneth Reitz | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* cc: Tom Forbes (added)
* has_patch: 0 => 1
Comment:
I've removed the WIP from my branch as I think the implementation is ready
to be discussed. I've got all tests to pass and a mechanism for
configuring both the caches and the databases via URLs.
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:5>
Django
Reporter: Kenneth Reitz | Owner: Tom
| Forbes
Type: New feature | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: settings, dj- | Triage Stage:
database-url, database_url | Someday/Maybe
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* owner: nobody => Tom Forbes
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28236#comment:6>