[Django] #27905: Admin RelatedFieldWidgetWrapper ignores custom value_omitted_from_data

5 views
Skip to first unread message

Django

unread,
Mar 6, 2017, 10:07:52 PM3/6/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores custom value_omitted_from_data
-----------------------------------------+------------------------------
Reporter: Raphael Merx | Owner: Raphael Merx
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------------
When using a custom widget for a related field in the admin, the
`value_omitted_from_data` method on the custom widget is ignored because
`RelatedFieldWidgetWrapper` does not delegate `value_omitted_from_data` to
the wrapped widget.

--
Ticket URL: <https://code.djangoproject.com/ticket/27905>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 6, 2017, 10:27:44 PM3/6/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores custom value_omitted_from_data
-------------------------------+----------------------------------------

Reporter: Raphael Merx | Owner: Raphael Merx
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Raphael Merx):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27905#comment:1>

Django

unread,
Mar 7, 2017, 1:16:52 PM3/7/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores wrapped widget's
value_omitted_from_data()
-------------------------------------+-------------------------------------

Reporter: Raphael Merx | Owner: Raphael
| Merx
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27905#comment:2>

Django

unread,
Mar 7, 2017, 1:56:38 PM3/7/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores wrapped widget's
value_omitted_from_data()
-------------------------------------+-------------------------------------
Reporter: Raphael Merx | Owner: Raphael
| Merx
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"2a3a0eb09231f7cade8fd945bf4af1b251df12e3" 2a3a0eb0]:
{{{
#!CommitTicketReference repository=""
revision="2a3a0eb09231f7cade8fd945bf4af1b251df12e3"
Fixed #27905 -- Added RelatedFieldWidgetWrapper.value_omitted_from_data().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27905#comment:3>

Django

unread,
Mar 7, 2017, 1:57:39 PM3/7/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores wrapped widget's
value_omitted_from_data()
-------------------------------------+-------------------------------------
Reporter: Raphael Merx | Owner: Raphael
| Merx
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"89b31b312e030c83e674d0b5898b51a4a460778b" 89b31b3]:
{{{
#!CommitTicketReference repository=""
revision="89b31b312e030c83e674d0b5898b51a4a460778b"
[1.11.x] Fixed #27905 – Added
RelatedFieldWidgetWrapper.value_omitted_from_data().

Backport of fd75c8f2b7070774f6e90f408cb5cddf65b8734e from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27905#comment:4>

Django

unread,
Mar 7, 2017, 2:02:20 PM3/7/17
to django-...@googlegroups.com
#27905: Admin RelatedFieldWidgetWrapper ignores wrapped widget's
value_omitted_from_data()
-------------------------------------+-------------------------------------
Reporter: Raphael Merx | Owner: Raphael
| Merx
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"c4b8c46345305ad975e12f6a9a086874e639575c" c4b8c463]:
{{{
#!CommitTicketReference repository=""
revision="c4b8c46345305ad975e12f6a9a086874e639575c"
[1.10.x] Fixed #27905 -- Added
RelatedFieldWidgetWrapper.value_omitted_from_data().

Backport of fd75c8f2b7070774f6e90f408cb5cddf65b8734e from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27905#comment:5>

Reply all
Reply to author
Forward
0 new messages