[Django] #32222: Unbalanced quotes in contrib/admin and contrib/gis templates.

1 view
Skip to first unread message

Django

unread,
Nov 23, 2020, 1:55:05 PM11/23/20
to django-...@googlegroups.com
#32222: Unbalanced quotes in contrib/admin and contrib/gis templates.
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: nobody
Larson |
Type: | Status: new
Cleanup/optimization |
Component: Template | Version: master
system | Keywords: templates, admin,
Severity: Normal | gis, quoting, quotes
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
There are several unbalanced quoting instances of the form {{{"\{% <tag>
"<str>" %\}"}}} in the `contrib/admin` and `contrib/gis` templates.

(Internal double-quotes should be single-quotes.)

I've read through the docs, and the ticket history, and the closest
discussion I've found of anything resembling a related issue or potential
complication dates back 13 years, and appears to have been addressed, in
ticket:7295

I've created a PR correcting this issue, replacing with the form {{{"{%
<tag> '<str>' %}"}}}, and will be submitting that now, but on the chance
this is a known thing, and not-be-changed, I'm tossing this ticket in the
mix for discussion.

This is (I believe) my first ticket, and first PR, so I welcome any meta
commentary vis-a-vis this ticket or the PR and community process. I've
read what I've found, but there's always room for improvement.

--
Ticket URL: <https://code.djangoproject.com/ticket/32222>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 23, 2020, 2:10:45 PM11/23/20
to django-...@googlegroups.com
#32222: Unbalanced quotes in contrib/admin and contrib/gis templates.
-------------------------------------+-------------------------------------
Reporter: Chris Larson | Owner: Chris
Type: | Larson
Cleanup/optimization | Status: assigned
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: templates, admin, | Triage Stage:
gis, quoting, quotes | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Chris Larson):

* owner: nobody => Chris Larson
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/32222#comment:1>

Django

unread,
Nov 23, 2020, 2:32:34 PM11/23/20
to django-...@googlegroups.com
#32222: Unbalanced quotes in contrib/admin and contrib/gis templates.
-------------------------------------+-------------------------------------
Reporter: Chris Larson | Owner: Chris
Type: | Larson
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: duplicate

Keywords: templates, admin, | Triage Stage:
gis, quoting, quotes | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* resolution: => duplicate
* component: Template system => Core (Other)


Comment:

Duplicate of #32192.

--
Ticket URL: <https://code.djangoproject.com/ticket/32222#comment:2>

Reply all
Reply to author
Forward
0 new messages