[Django] #30766: Refactor ExceptionReporter to allow overriding cookies filter.

2 views
Skip to first unread message

Django

unread,
Sep 5, 2019, 4:18:25 PM9/5/19
to django-...@googlegroups.com
#30766: Refactor ExceptionReporter to allow overriding cookies filter.
------------------------------------------------+------------------------
Reporter: Nasir Hussain | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Since now we are allowing to use custom ExceptionRepoter subclass in
#29714. We should refactor ExceptionReporter and move
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
cookies] extraction to a function like we are doing for POST
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
here] so that It is easy to override sensitive cookies filtering in the
custom subclass of ExceptionRepoter.

--
Ticket URL: <https://code.djangoproject.com/ticket/30766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 5, 2019, 4:27:59 PM9/5/19
to django-...@googlegroups.com
#30766: Make it easier to override custom ExceptionReporter subclass functions.
-------------------------------------+-------------------------------------

Reporter: Nasir Hussain | Owner: (none)
Type: | Status: new
Cleanup/optimization |

Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nasir Hussain):

* has_patch: 0 => 1


Old description:

> Since now we are allowing to use custom ExceptionRepoter subclass in
> #29714. We should refactor ExceptionReporter and move
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
> cookies] extraction to a function like we are doing for POST
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
> here] so that It is easy to override sensitive cookies filtering in the
> custom subclass of ExceptionRepoter.

New description:

Since now we are allowing to use custom ExceptionRepoter subclass in
#29714. We should refactor ExceptionReporter and move
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
cookies] extraction to a function like we are doing for POST
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
here] so that It is easy to override sensitive cookies filtering in the
custom subclass of ExceptionRepoter.

[https://github.com/django/django/pull/11748 Patch], I could add unit
tests if required.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:1>

Django

unread,
Sep 5, 2019, 4:37:35 PM9/5/19
to django-...@googlegroups.com
#30766: Make it easier to override ExceptionReporter functions in custom subclass.
-------------------------------------+-------------------------------------

Reporter: Nasir Hussain | Owner: (none)
Type: | Status: new
Cleanup/optimization |

Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:2>

Django

unread,
Sep 5, 2019, 4:44:41 PM9/5/19
to django-...@googlegroups.com
#30766: Make it easier to override ExceptionReporter functions in custom subclass.
-------------------------------------+-------------------------------------
Reporter: Nasir Hussain | Owner: (none)
Type: | Status: closed
Cleanup/optimization |

Component: Error reporting | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nasir Hussain):

* status: new => closed
* resolution: => invalid


--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:3>

Reply all
Reply to author
Forward
0 new messages