[Django] #29749: allow private packages in migrations (regression)

[Django]

#29749: allow private packages in migrations (regression)
---------------------------------------+------------------------
Reporter: felixhummel | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------
Steps:

- create a module `_utils.py` in `someapp.migrations`
- run `./manage.py migrate`

Expected:

- migrations are run

Actual:

- `django.db.migrations.exceptions.BadMigrationError: Migration _utils in
app someapp has no Migration class`

Notes:

- Commit that changed the behavior:
https://github.com/django/django/commit/29150d5da880ac1db15e47052330790cf1b802d2
#diff-a0eecbfcd2a528c7502db192412c5a16L106
- IRC conversation (thanks to knbk for the link to the commit)
https://botbot.me/freenode/django/2018-09-10/?msg=104204672&page=8 and
https://botbot.me/freenode/django/2018-09-10/?msg=104204672&page=9

--
Ticket URL: <https://code.djangoproject.com/ticket/29749>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#29749: Reallow private packages in migrations
---------------------------------+------------------------------------

Reporter: felixhummel | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 2.1

Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------
Changes (by Tim Graham):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/29749#comment:1>

[Django]

#29749: Make the migrations loader ignore files starting with an underscore or
tilde
---------------------------------+------------------------------------
Reporter: Felix Hummel | Owner: nobody

Type: Bug | Status: new
Component: Migrations | Version: 2.1

Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/10379 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/29749#comment:2>

[Django]

#29749: Make the migrations loader ignore files starting with an underscore or
tilde
---------------------------------+------------------------------------

Reporter: Felix Hummel | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------
Changes (by GitHub <noreply@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"32fbccab406b680bc0a0a8d39a9b95c3a08bbc5a" 32fbccab]:
{{{
#!CommitTicketReference repository=""
revision="32fbccab406b680bc0a0a8d39a9b95c3a08bbc5a"
Fixed #29749 -- Made the migrations loader ignore files starting with a
tilde or underscore.

Regression in 29150d5da880ac1db15e47052330790cf1b802d2.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29749#comment:3>

[Django]

#29749: Make the migrations loader ignore files starting with an underscore or
tilde
---------------------------------+------------------------------------

Reporter: Felix Hummel | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.1

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"5bbcf83fce5e5fb1d7369f2bfb81b7e06a4b1a85" 5bbcf83]:
{{{
#!CommitTicketReference repository=""
revision="5bbcf83fce5e5fb1d7369f2bfb81b7e06a4b1a85"
[2.1.x] Fixed #29749 -- Made the migrations loader ignore files starting

with a tilde or underscore.

Regression in 29150d5da880ac1db15e47052330790cf1b802d2.
Backport of 32fbccab406b680bc0a0a8d39a9b95c3a08bbc5a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29749#comment:4>