[Django] #28048: Generic date views don't work with related fields as date_field
Django
-------------------------------------+-------------------------------------
Reporter: Lefteris | Owner: Lefteris Nikoltsios
Nikoltsios |
Type: | Status: assigned
Uncategorized |
Component: Generic | Version: 1.11
views |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
For example if we have some models like that:
{{{
class Blog(models.Model):
title = models.TextField()
pubdate = models.DateField()
class Article(models.Model):
blog = models.ForeignKey(Blog)
title = models.TextFIeld()
pubdate = models.DateField()
}}}
the following view:
{{{
from django.views.generic.dates import MonthArchiveView
from .models import Article
class ArticleMonthArchiveView(MonthArchiveView):
queryset = Article.objects.all()
date_field = 'blog__pub_date'
}}}
will raise FieldDoesNotExist.
--
Ticket URL: <https://code.djangoproject.com/ticket/28048>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| Nikoltsios
Type: Uncategorized | Status: assigned
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/8307 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Lefteris Nikoltsios | Owner: Lefteris
| Nikoltsios
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Lefteris Nikoltsios | Owner: Lefteris
| Nikoltsios
Type: New feature | Status: assigned
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Lefteris Nikoltsios | Owner: Lefteris
| Nikoltsios
Type: New feature | Status: assigned
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Lefteris Nikoltsios | Owner: Lefteris
| Nikoltsios
Type: New feature | Status: assigned
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Jaap Roes (added)
Comment:
I created issue #32846 which was marked as a duplicate. Looking at the
patch provided for this ticket is seems that the most difficult part is
the lack of an "official" way of resolving "field paths" like
`blog__pub_date` to fields. Django admin provides some utility methods,
but since it is a contrib app it cannot be used in other "core" Django
code.
Is there a separate ticket that tracks this? (I couldn't find one.) The
addition of a canonical way to resolve field paths could also be helpful
for 3rd party apps, for example django-filter has it's own implementation:
https://github.com/carltongibson/django-
filter/blob/f507201addfb7f105e722573f3ced4b4a9870526/django_filters/utils.py#L143,
and I'm certain there are others.
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:5>
Django
-------------------------------------+------------------------------------
Type: New feature | Status: new
Component: Generic views | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* owner: Lefteris Nikoltsios => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:6>
Django
-------------------------------------+------------------------------------
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
-------------------------------------+------------------------------------
* owner: (none) => Saurabh
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28048#comment:7>