[Django] #21937: Add forms_valid for the mixin to work with django-extra-view's UpdateWithInlinesView

12 views
Skip to first unread message

Django

unread,
Feb 3, 2014, 6:20:14 AM2/3/14
to django-...@googlegroups.com
#21937: Add forms_valid for the mixin to work with django-extra-view's
UpdateWithInlinesView
------------------------------------+-------------------------------
Reporter: david.fischer.ch@… | Owner: nobody
Type: New feature | Status: new
Component: contrib.messages | Version: master
Severity: Normal | Keywords: extra-views,mixin
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
------------------------------------+-------------------------------
For my own purposes I am using on of the mixins of the project called
django-extra-views.

This mixin uses a method called forms_valid that was missing to allow
using the messages framework too.

--
Ticket URL: <https://code.djangoproject.com/ticket/21937>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 9, 2014, 7:33:00 AM2/9/14
to django-...@googlegroups.com
#21937: Add forms_valid for the mixin to work with django-extra-view's
UpdateWithInlinesView
------------------------------------+--------------------------------------
Reporter: david.fischer.ch@… | Owner: nobody
Type: New feature | Status: closed
Component: contrib.messages | Version: master
Severity: Normal | Resolution: invalid

Keywords: extra-views,mixin | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
------------------------------------+--------------------------------------
Changes (by mjtamlyn):

* status: new => closed
* needs_better_patch: => 0
* resolution: => invalid
* needs_tests: => 0
* needs_docs: => 0


Comment:

This patch would more logically live in `django-extra-views`, providing an
overridden version of `SuccessMessageMixin`. We cannot possibly support
all possible external packages in this way.

--
Ticket URL: <https://code.djangoproject.com/ticket/21937#comment:1>

Reply all
Reply to author
Forward
0 new messages