Re: [Django] #14807: django.utils.formats localize_input inserts thousands_separator into boolean values
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: vanschelven | Owner: nobody
Type: Uncategorized | Status: new
Component: | Version: 1.2
Internationalization | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by klaas@…):
* status: closed => new
* severity: => Normal
* type: => Uncategorized
* easy: => 0
* ui_ux: => 0
* resolution: fixed =>
Comment:
When fixing this, input_localize was missed. My proposed solution (which
is unfortunately not formatted as a pull request, nor does it have tests)
is here:
https://github.com/vanschelven/django/commit/f0e39c83ec9174b8e5241caa6ba59b8e2e6deb66
Also copying my notes from that solution to justify reopening the issue:
6c53a81 only fixed localize(), but not localize_input()
It appears to me that this was simply an oversight at the time.
It seems that a new call-order for fields somewhere between Django 1.4
and Django 1.6 triggers triggers this bug again, but this time on the
inputs
and only when rendering fields as_hidden.
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: vanschelven | Owner: nobody
Component: | Version: 1.2
Internationalization | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
I'll be better to open a new ticket rather than reopening one that's three
years old where the original fix has already been released, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:8>
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: vanschelven | Owner: nobody
Type: Uncategorized | Status: closed
Component: | Version: 1.2
Internationalization | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by vanschelven):
So was the new ticket created? Or am I expected to do this?
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:9>
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: vanschelven | Owner: nobody
Type: Uncategorized | Status: closed
Component: | Version: 1.2
Internationalization | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timo):
Please do it, thank-you.
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:10>
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: vanschelven | Owner: nobody
Type: Uncategorized | Status: closed
Component: | Version: 1.2
Internationalization |
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timgraham):
The follow up ticket is #26173.
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:11>
Django
boolean values
-------------------------------------+-------------------------------------
Type: Uncategorized | Status: closed
Component: | Version: 1.2
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"68407e3545f4b3e051c87cd530c97765bf2cdd80" 68407e35]:
{{{
#!CommitTicketReference repository=""
revision="68407e3545f4b3e051c87cd530c97765bf2cdd80"
Refs #14807 -- Removed unneeded mark_safe call
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:12>
Django
boolean values
-------------------------------------+-------------------------------------
Reporter: Klaas van Schelven | Owner: nobody
Type: Uncategorized | Status: closed
Component: | Version: 1.2
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"f6ea7c139f6030355ba4c6a6a2da2d2ef88c61b9" f6ea7c13]:
{{{
#!CommitTicketReference repository=""
revision="f6ea7c139f6030355ba4c6a6a2da2d2ef88c61b9"
[2.0.x] Refs #14807 -- Removed unneeded mark_safe call
Backport of 68407e3545f4b3e051c87cd530c97765bf2cdd80 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14807#comment:13>