[Django] #23136: sqlclear does not notify operator that there is nothing to clear

Django

unread,

Jul 30, 2014, 5:00:57 PM7/30/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear
--------------------------------------------+--------------------
Reporter: jackiekazil | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Management commands) | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------------+--------------------
I tried passing sqlclear to dbshell and came up with this error, which was
non-descript.
{{{
$ django-admin.py sqlclear foia_core | django-admin.py dbshell
ERROR: syntax error at or near "/"
LINE 1: /Users/jacquelinekazil/Projects/code/foia/foia-core/foia_cor...
}}}

Then I tried running each command separately. When I ran sqlclear, nothing
appeared to happened.
{{{
$ django-admin.py sqlclear foia_core
$
}}}

This is confusing to user if they are expecting something to happen. There
should be output to tell the user what happened.
Example: Foo app has no tables in the database.

--
Ticket URL: <https://code.djangoproject.com/ticket/23136>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Jul 30, 2014, 5:05:07 PM7/30/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.6
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by russellm):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted

Comment:

Sounds reasonable, and shouldn't be too hard to implement either. Might be
worth checking if other sql* commands are also affected as well.

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:1>

Django

unread,

Jul 30, 2014, 5:27:27 PM7/30/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: nobody

Comment (by timo):

I believe most of the sql* commands besides sqlmigrate are headed down the
deprecation path, so this might not be worth it.

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:2>

Django

unread,

Jul 30, 2014, 5:43:52 PM7/30/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: nobody

Comment (by gmunumel):

I´d like to implement this if there is not objection.

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:3>

Django

unread,

Jul 30, 2014, 5:44:09 PM7/30/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: gmunumel
Type: | Status: assigned

Changes (by gmunumel):

* owner: nobody => gmunumel
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:4>

Django

unread,

Aug 4, 2014, 6:42:57 PM8/4/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

Comment (by gmunumel):

PR:
https://github.com/gmunumel/django/commit/c85ac9b7929d07793b33101468d96fb09ff8d90a

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:5>

Django

unread,

Aug 4, 2014, 7:06:13 PM8/4/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

Comment (by timo):

Couple of issues:
- New features are going to master only (not 1.6).
- I only see a test in your commit, not the functional changes (and it
isn't an actual pull request).

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:6>

Django

unread,

Aug 4, 2014, 8:34:56 PM8/4/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

Comment (by gmunumel):

New attempt: https://github.com/django/django/pull/3024

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:7>

Django

unread,

Aug 5, 2014, 7:54:07 AM8/5/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: gmunumel
Type: | Status: assigned

Cleanup/optimization | Version: master

Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0

Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0

Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------

Changes (by timo):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* version: 1.6 => master

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:8>

Django

unread,

Aug 6, 2014, 6:23:16 PM8/6/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

Comment (by gmunumel):

I made the changes Timo

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:9>

Django

unread,

Aug 21, 2014, 11:03:05 AM8/21/14

to django-...@googlegroups.com

#23136: sqlclear does not notify operator that there is nothing to clear

-------------------------------------+-------------------------------------
Reporter: jackiekazil | Owner: gmunumel

Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Management | Resolution: fixed

Changes (by timgraham):

* status: assigned => closed
* resolution: => fixed

Comment:

In 3e241313a4cea5dbf53068181408a7c34f00c9ca:

Fixed #23136 -- Added a message when sqlclear does nothing

--
Ticket URL: <https://code.djangoproject.com/ticket/23136#comment:10>

Reply all

Reply to author

Forward