[Django] #29683: View permissions were added by default in Django 2.1 but docs remained out of date.

6 views
Skip to first unread message

Django

unread,
Aug 17, 2018, 10:06:34 AM8/17/18
to django-...@googlegroups.com
#29683: View permissions were added by default in Django 2.1 but docs remained out
of date.
-------------------------------------+-------------------------------------
Reporter: Ariel | Owner: nobody
Pontes |
Type: | Status: new
Cleanup/optimization |
Component: | Version: 2.1
Documentation |
Severity: Normal | Keywords: permissions
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Since Django 2.1, view permissions are added by default. However, parts of
the documentation were not updated. For example:

[https://github.com/django/django/blob/97e637a87fb45c4de970cca6cb783d93473c9d15/django/contrib/auth/models.py#L33
The docstring in the Permissions model] ("Three basic permissions […]")
[https://github.com/django/django/blob/31407fa3b362dc17d61a2a0d7e27b1dfd9d9c143/docs/topics/auth/default.txt#L199
The docs on Default permissions] ("… three default permissions …")
[https://github.com/django/django/blob/e9ea49d2740b6f99b4ecc424c1a9ed87905e481e/docs/topics/auth/customizing.txt#L276
The docs on Custom permissions] (it says the example includes 3 custom
permissions, but in fact only 2 are custom, because the view permission is
now default)
[https://github.com/django/django/blob/35319bf12ccefe1911588493484160aa49208f89/docs/topics/testing/advanced.txt#L252
The docs on the Advanced features of TransactionTestCase] (again, it says
3 permissions are created by default)

--
Ticket URL: <https://code.djangoproject.com/ticket/29683>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 17, 2018, 10:40:59 AM8/17/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
--------------------------------------+------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: permissions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:1>

Django

unread,
Aug 17, 2018, 2:54:02 PM8/17/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned

Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: permissions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Srinivas Reddy Thatiparthy):

* owner: nobody => Srinivas Reddy Thatiparthy
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:2>

Django

unread,
Sep 24, 2018, 1:23:23 PM9/24/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: permissions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Clint Dunn):

Can I work on this?

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:3>

Django

unread,
Sep 26, 2018, 2:32:38 PM9/26/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

[https://github.com/django/django/pull/10449 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:4>

Django

unread,
Sep 26, 2018, 3:07:08 PM9/26/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed

Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"e40e7026cad400d720963aea0ba156a19f83b058" e40e702]:
{{{
#!CommitTicketReference repository=""
revision="e40e7026cad400d720963aea0ba156a19f83b058"
Fixed #29683 -- Added view permission to docs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:5>

Django

unread,
Sep 26, 2018, 3:07:35 PM9/26/18
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"f5335bc745d4f86d355b69549712885fd1634574" f5335bc7]:
{{{
#!CommitTicketReference repository=""
revision="f5335bc745d4f86d355b69549712885fd1634574"
[2.1.x] Fixed #29683 -- Added view permission to docs.

Backport of e40e7026cad400d720963aea0ba156a19f83b058 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:6>

Django

unread,
Feb 25, 2019, 2:57:34 PM2/25/19
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"50f09264ae8ab04824fcc6554e8c184378ad2f81" 50f0926]:
{{{
#!CommitTicketReference repository=""
revision="50f09264ae8ab04824fcc6554e8c184378ad2f81"
Refs #29683 -- Updated multi-db docs for view permission.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:7>

Django

unread,
Feb 25, 2019, 2:57:43 PM2/25/19
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"8205116a79546bad64a065b47883a81e119451cf" 8205116]:
{{{
#!CommitTicketReference repository=""
revision="8205116a79546bad64a065b47883a81e119451cf"
[2.2.x] Refs #29683 -- Updated multi-db docs for view permission.

Backport of 50f09264ae8ab04824fcc6554e8c184378ad2f81 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:8>

Django

unread,
Feb 25, 2019, 2:57:59 PM2/25/19
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"8205116a79546bad64a065b47883a81e119451cf" 8205116]:
{{{
#!CommitTicketReference repository=""
revision="8205116a79546bad64a065b47883a81e119451cf"
[2.2.x] Refs #29683 -- Updated multi-db docs for view permission.

Backport of 50f09264ae8ab04824fcc6554e8c184378ad2f81 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:9>

Django

unread,
Feb 25, 2019, 2:57:59 PM2/25/19
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0c295a757085b2fecf7a336c08debf1ab82ca80d" 0c295a75]:
{{{
#!CommitTicketReference repository=""
revision="0c295a757085b2fecf7a336c08debf1ab82ca80d"
[2.1.x] Refs #29683 -- Updated multi-db docs for view permission.

Backport of 50f09264ae8ab04824fcc6554e8c184378ad2f81 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:10>

Django

unread,
Feb 25, 2019, 2:58:09 PM2/25/19
to django-...@googlegroups.com
#29683: Add the view permission to several places in the docs
-------------------------------------+-------------------------------------
Reporter: Ariel Pontes | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: permissions | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0c295a757085b2fecf7a336c08debf1ab82ca80d" 0c295a75]:
{{{
#!CommitTicketReference repository=""
revision="0c295a757085b2fecf7a336c08debf1ab82ca80d"
[2.1.x] Refs #29683 -- Updated multi-db docs for view permission.

Backport of 50f09264ae8ab04824fcc6554e8c184378ad2f81 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29683#comment:11>

Reply all
Reply to author
Forward
0 new messages