Re: [Django] #31934: Document that "SameSite" has defaults in some browsers.

26 views
Skip to first unread message

Django

unread,
Aug 24, 2020, 8:30:27 AM8/24/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
--------------------------------------+------------------------------------
Reporter: אורי | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Hasan Ramezani):

I've created a [https://github.com/django/django/pull/13342 PR] based on
Mariusz suggestion.

--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 24, 2020, 9:09:16 AM8/24/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
--------------------------------------+------------------------------------
Reporter: אורי | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by אורי):

Replying to [comment:5 Hasan Ramezani]:


> I've created a [https://github.com/django/django/pull/13342 PR] based on
Mariusz suggestion.

I think we should also change the relevant documentation for Django 2.2 +
3.0, which is different (there is no `False` there). Maybe add the same
line after "**None**: disables the flag.". (or maybe you can start with a
new line and use the same PR for all versions).

--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:6>

Django

unread,
Aug 25, 2020, 4:50:23 AM8/25/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
-------------------------------------+-------------------------------------
Reporter: אורי | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned

Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* owner: nobody => Hasan Ramezani
* status: new => assigned
* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:7>

Django

unread,
Aug 26, 2020, 4:58:03 AM8/26/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
-------------------------------------+-------------------------------------
Reporter: אורי | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:8>

Django

unread,
Aug 31, 2020, 6:33:18 AM8/31/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
-------------------------------------+-------------------------------------
Reporter: אורי | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"70731fc6feeb40eab535781e938b0e67ff0077ad" 70731fc]:
{{{
#!CommitTicketReference repository=""
revision="70731fc6feeb40eab535781e938b0e67ff0077ad"
Fixed #31934 -- Added note about the default of SameSite cookie flag in
modern browsers.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:9>

Django

unread,
Aug 31, 2020, 6:33:44 AM8/31/20
to django-...@googlegroups.com
#31934: Document that "SameSite" has defaults in some browsers.
-------------------------------------+-------------------------------------
Reporter: אורי | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"eda59ba2ec9cee3e11a938171fdc93ea058e9dc9" eda59ba]:
{{{
#!CommitTicketReference repository=""
revision="eda59ba2ec9cee3e11a938171fdc93ea058e9dc9"
[3.1.x] Fixed #31934 -- Added note about the default of SameSite cookie
flag in modern browsers.

Backport of 70731fc6feeb40eab535781e938b0e67ff0077ad from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31934#comment:10>

Reply all
Reply to author
Forward
0 new messages