[Django] #25097: No delete hook method on ModelFormSets

16 views
Skip to first unread message

Django

unread,
Jul 10, 2015, 2:02:33 AM7/10/15
to django-...@googlegroups.com
#25097: No delete hook method on ModelFormSets
-------------------------------+--------------------
Reporter: litchfield | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
There are hooks to override how instances in a ModelFormSet are saved
(save_new, save_existing), which is great. But there's no hook to override
deletions.

https://github.com/litchfield/django/commit/1204ccc9e90ef02769548b05dd4e22f540e8e9f9

--
Ticket URL: <https://code.djangoproject.com/ticket/25097>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 10, 2015, 2:03:57 AM7/10/15
to django-...@googlegroups.com
#25097: No delete hook method on ModelFormSets
-----------------------------+--------------------------------------

Reporter: litchfield | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-----------------------------+--------------------------------------
Changes (by litchfield):

* needs_docs: => 0
* component: contrib.admin => Forms
* needs_tests: => 0
* needs_better_patch: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25097#comment:1>

Django

unread,
Jul 10, 2015, 10:48:21 AM7/10/15
to django-...@googlegroups.com
#25097: Add a delete hook method on ModelFormSets
-----------------------------+------------------------------------

Reporter: litchfield | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/25097#comment:2>

Django

unread,
Jul 14, 2015, 9:07:32 AM7/14/15
to django-...@googlegroups.com
#25097: Add a delete hook method on ModelFormSets
-----------------------------+------------------------------------
Reporter: litchfield | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: 1.8
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"0ffa3943fbd100e7de7b1ddbfd301ddc52b57410" 0ffa3943]:
{{{
#!CommitTicketReference repository=""
revision="0ffa3943fbd100e7de7b1ddbfd301ddc52b57410"
Fixed #25097 -- Added BaseModelFormSet.delete_existing() hook.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25097#comment:3>

Reply all
Reply to author
Forward
0 new messages